Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add option to search multiple subnets with cloud-instance launch #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Feb 27, 2025
Merged

Add option to search multiple subnets with cloud-instance launch #3201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions scripts/infra/cloud-instance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,30 @@ else
fi

ec2__launch() {
local instance_id
instance_id="$(aws ec2 run-instances \
--image-id "$EC2_AMI_ID" \
--region "$EC2_REGION" \
--instance-type "${INSTANCE_TYPE:-$EC2_INSTANCE_TYPE}" \
--security-group-ids "$EC2_SECURITY_GROUP_ID" \
--subnet-id "$EC2_SUBNET_ID" \
--key-name "$EC2_KEY_NAME" \
--block-device-mappings '{"DeviceName": "/dev/sda1","Ebs": {"VolumeSize": 800}}' \
--associate-public-ip-address \
--tag-specifications "ResourceType=instance,Tags=[{Key=Name,Value=$INSTANCE_NAME}]" \
"ResourceType=volume,Tags=[{Key=Name,Value=$INSTANCE_NAME}]" \
--query 'Instances[0].InstanceId' \
--output text)" &> /dev/null
if [ -z ${EC2_SUBNET_VARS+x} ]; then
EC2_SUBNET_VARS=("EC2_SUBNET_ID")
fi

for subnet_var in "${EC2_SUBNET_VARS[@]}"; do
subnet="${!subnet_var}"
echo "Attempting to launch an instance of type $EC2_INSTANCE_TYPE in subnet $subnet named $INSTANCE_NAME"
local instance_id
if instance_id="$(aws ec2 run-instances \
--image-id "$EC2_AMI_ID" \
--region "$EC2_REGION" \
--instance-type "${INSTANCE_TYPE:-$EC2_INSTANCE_TYPE}" \
--security-group-ids "$EC2_SECURITY_GROUP_ID" \
--subnet-id "$subnet" \
--key-name "$EC2_KEY_NAME" \
--block-device-mappings '{"DeviceName": "/dev/sda1","Ebs": {"VolumeSize": 800}}' \
--associate-public-ip-address \
--tag-specifications "ResourceType=instance,Tags=[{Key=Name,Value=$INSTANCE_NAME}]" \
"ResourceType=volume,Tags=[{Key=Name,Value=$INSTANCE_NAME}]" \
--query 'Instances[0].InstanceId' \
--output text)" &> /dev/null; then
break
fi
done

if [ -z "$instance_id" ]; then
echo "Failed to launch instance"
Expand Down
4 changes: 4 additions & 0 deletions scripts/infra/instructlab-cloud-config-example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ EC2_INSTANCE_TYPE="m4.large"
# Nvidia 1x A10 GPU, 24GB VRAM
#EC2_INSTANCE_TYPE="g5.4xlarge"
EC2_SECURITY_GROUP_ID="sg-12345678901234567"
# EC2_SUBNET_ID is ignored if you specify EC2_SUBNET_VARS which searches across the specified subnets for an available instance on launch
EC2_SUBNET_ID="subnet-12345678901234567"
EC2_SUBNET_VARS=("EC2_SUBNET_ID_1" "EC2_SUBNET_ID_2")
EC2_SUBNET_ID_1=subnet-12345678901234567
EC2_SUBNET_ID_2=subnet-12345678901234568
EC2_AMI_ID="ami-12345678901234567"
EC2_REGION="us-east-2"
EC2_INSTANCE_NAME=`whoami`
Expand Down