Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: update docling api references #3254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaideepr97 merged 1 commit into from
Apr 8, 2025
Merged

chore: update docling api references #3254

jaideepr97 merged 1 commit into from
Apr 8, 2025

Conversation

@jaideepr97
Copy link
Member

@jaideepr97 jaideepr97 commented Apr 2, 2025

bring changes in https://github.com/instructlab/sdg/pull/574/files to instructlab

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added testing Relates to testing dependencies Relates to dependencies ci-failure PR has at least one CI failure labels Apr 2, 2025
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 2, 2025
@jaideepr97 jaideepr97 linked an issue Apr 2, 2025 that may be closed by this pull request
mypy failures on main #3253
Closed
@jaideepr97 jaideepr97 mentioned this pull request Apr 2, 2025
Closed
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 2, 2025
@mergify mergify bot added CI/CD Affects CI/CD configuration ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 3, 2025
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 3, 2025
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 3, 2025
@RobotSail RobotSail mentioned this pull request Apr 6, 2025
Merged
@jaideepr97 jaideepr97 force-pushed the update-docling branch 2 times, most recently from 171f1e1 to 4cf1092 Compare April 7, 2025 14:19
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 7, 2025
booxter
booxter reviewed Apr 7, 2025
View reviewed changes
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 7, 2025
@jaideepr97
Copy link
Member Author

jaideepr97 commented Apr 8, 2025

FYI CI failure is because of training library "mocking" the transformers forward method in an unsafe way: instructlab/training#443

You may want to pin an older transformers library version until training fixes the issue.

UPD: it's not just "may" but "have to". The training library fix for the new transformers version can't land until this PR here lands. This catch-22 can be solved by first capping transformers library here; then later uncapping when training release fixes the problem.

Thanks a lot for digging into this and for the helpful pointer! @booxter
capped it at 4.51.0 for now

@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 8, 2025
booxter
booxter reviewed Apr 8, 2025
View reviewed changes
@mergify mergify bot added the ci-failure PR has at least one CI failure label Apr 8, 2025
@mergify mergify bot removed the ci-failure PR has at least one CI failure label Apr 8, 2025
@booxter booxter requested a review from a team April 8, 2025 14:53
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 8, 2025
@booxter booxter requested a review from a team April 8, 2025 15:31
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 8, 2025
RobotSail
RobotSail approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Apr 8, 2025
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 8, 2025
@jaideepr97 jaideepr97 merged commit 085da8b into instructlab:main Apr 8, 2025
24 checks passed
@courtneypacheco
Copy link
Contributor

courtneypacheco commented Apr 8, 2025

@mergify backport release-v0.23

@mergify
Copy link
Contributor

mergify bot commented Apr 8, 2025 •
edited
Loading

backport release-v0.23

✅ Backports have been created

Details

@mergify mergify bot mentioned this pull request Apr 8, 2025
Closed
6 tasks
@courtneypacheco
Copy link
Contributor

courtneypacheco commented Apr 8, 2025

@mergify backport release-v0.24

@mergify
Copy link
Contributor

mergify bot commented Apr 8, 2025 •
edited
Loading

backport release-v0.24

✅ Backports have been created

Details

@mergify mergify bot mentioned this pull request Apr 8, 2025
Closed
6 tasks
This was referenced Apr 8, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktdreyer ktdreyer ktdreyer left review comments

@courtneypacheco courtneypacheco courtneypacheco approved these changes

@RobotSail RobotSail RobotSail approved these changes

+1 more reviewer

@booxter booxter booxter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Affects CI/CD configuration dependencies Relates to dependencies testing Relates to testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

mypy failures on main

5 participants

@jaideepr97 @booxter @courtneypacheco @ktdreyer @RobotSail