Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@courtneypacheco
Copy link
Contributor

@courtneypacheco courtneypacheco commented Apr 8, 2025

Reverts #3254 because the unit + functional tests didn't run on that PR.

We just need to update the syntax in .github/workflows/test.yml like this to get the unit + functional tests to run.

@mergify mergify bot added CI/CD Affects CI/CD configuration testing Relates to testing ci-failure PR has at least one CI failure dependencies Relates to dependencies labels Apr 8, 2025
@courtneypacheco courtneypacheco force-pushed the revert-3254-update-docling branch from 12a2de5 to ae16698 Compare April 8, 2025 22:17
@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 8, 2025
Copy link
Contributor Author

@courtneypacheco courtneypacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These linting failures are to be expected with the revert because core is now consuming instructlab-sdg==0.7.3. This release contains changes to docling syntaxt/typing, which are incompatible with our current repo's source code.

@courtneypacheco courtneypacheco marked this pull request as ready for review April 8, 2025 22:33
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Apr 9, 2025
@courtneypacheco
Copy link
Contributor Author

Merging this.

@courtneypacheco courtneypacheco merged commit adb85a8 into main Apr 9, 2025
17 of 28 checks passed
@courtneypacheco courtneypacheco deleted the revert-3254-update-docling branch April 9, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration ci-failure PR has at least one CI failure dependencies Relates to dependencies one-approval PR has one approval from a maintainer testing Relates to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants