Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jaideepr97
Copy link
Member

temporarily disable macOS workflow until it can be sufficiently debugged without blocking high priority PRs

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the
    conventional commits.
  • Changelog updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Functional tests have been added, if necessary.
  • E2E Workflow tests have been added, if necessary.

@mergify mergify bot added CI/CD Affects CI/CD configuration ci-failure PR has at least one CI failure labels Apr 9, 2025
@booxter
Copy link
Contributor

booxter commented Apr 9, 2025

We should at least report a bug to re-enable the tests explaining how it fails right now; then link to the bug from this patch.

@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 9, 2025
@mergify mergify bot added the one-approval PR has one approval from a maintainer label Apr 9, 2025
Copy link
Contributor

@ktdreyer ktdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve. In the future I recommend deleting config sections entirely so it is easier to read and cherry-pick changes.

@mergify mergify bot removed the one-approval PR has one approval from a maintainer label Apr 9, 2025
@jaideepr97
Copy link
Member Author

I'll approve. In the future I recommend deleting config sections entirely so it is easier to read and cherry-pick changes.

understood!

@jaideepr97
Copy link
Member Author

@ktdreyer updated

@mergify mergify bot added ci-failure PR has at least one CI failure and removed ci-failure PR has at least one CI failure labels Apr 9, 2025
@jaideepr97
Copy link
Member Author

We should at least report a bug to re-enable the tests explaining how it fails right now; then link to the bug from this patch.

#3273

@jaideepr97 jaideepr97 merged commit 2c49016 into instructlab:main Apr 9, 2025
13 of 18 checks passed
@courtneypacheco
Copy link
Contributor

@mergify backport release-v0.23

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

backport release-v0.23

✅ Backports have been created

Details

@courtneypacheco
Copy link
Contributor

courtneypacheco commented Apr 10, 2025

@mergify backport release-v0.24

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

backport -release-v0.24

❌ No backport have been created

Details
  • Backport to branch -release-v0.24 failed

GitHub error: Branch not found

@mergify
Copy link
Contributor

mergify bot commented Apr 10, 2025

backport release-v0.24

✅ Backports have been created

Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Affects CI/CD configuration ci-failure PR has at least one CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants