ci: temporarily disable small job on PRs #3290
Conversation
booxter
left a comment
There was a problem hiding this comment.
I think you should also disable the check-success~=e2e-small-workflow-complete condition in .github/mergify.yml to allow mergify to merge patches without the results from the job.
| - '.github/workflows/e2e-nvidia-t4-x1.yml' # This workflow | ||
|
|
||
| # temporarily disable this job on pull requests until | ||
| # https://github.com/instructlab/instructlab/issues/3289 is resolved |
There was a problem hiding this comment.
setting if: false to the job could be a more fine grained change: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idif
|
Looks like GH Actions is still running the To test this, could you please try pushing your work-in-progress branch to the main repository https://github.com/instructlab/instructlab , rather than your fork? |
Signed-off-by: Jaideep Rao <[email protected]>
957cdde to
3a53869
Compare
@ktdreyer so the PR should come from a branch rather than my fork? |
|
Yeah, I'm sorry for steering you wrong here. I read more about Since |
courtneypacheco
left a comment
There was a problem hiding this comment.
This change won't take effect until merged, so we'll have to merge this first. Let's merge
Simple pipeline hasn't been working for some time now, due to #3289 . I've tracked the issue down in [transformers utils.py](https://github.com/huggingface/transformers/blob/main/src/transformers/generation/utils.py#L3434 ). It appears that usage of torchscript, is changing type of output from invocations of `GenerationMixin` objects. I'm not sure about the exact reason why is this happening. But the behavior is normalized by simply removing `torchscript` parameter from config. Since purpose of [Torchscript](https://pytorch.org/tutorials/beginner/Intro_to_TorchScript_tutorial.html) is to improve performance, I can guess that merging this fix may cause the pipeline to run a bit slower. But at least it will run. Proper fix should be implemented in transformers, but I don't have enough experience with the code base to know what to look for. I'm also reverting #3290 since things should be working now. **Checklist:** - [x] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [x] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [x] Documentation has been updated, if necessary. - [x] Unit tests have been added, if necessary. - [x] Functional tests have been added, if necessary. - [x] E2E Workflow tests have been added, if necessary. Approved-by: booxter Approved-by: RobotSail
Temporarily disable the small job on PRs until #3289 is investigated
this is simply to prevent blocking important changes that need to go in
Checklist:
conventional commits.