fix: Removing torchscript from autoconfig (backport #3307) #3332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaideep Rao <[email protected]> (cherry picked from commit 8ea9979)
missed adding logic to pick up teacher model id from config in earlier PR. This PR fixes that **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. <hr>This is an automatic backport of pull request #3309 done by [Mergify](https://mergify.com). Approved-by: courtneypacheco Approved-by: jaideepr97
Signed-off-by: Jiri Podivin <[email protected]> (cherry picked from commit 7a55400)
This reverts commit 3a53869. Signed-off-by: Jiri Podivin <[email protected]> (cherry picked from commit 9f90f9f)
6 tasks
cdoern
approved these changes
Apr 30, 2025
Contributor
|
Unit tests fail because we need: #3329 |
booxter
approved these changes
Apr 30, 2025
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple pipeline hasn't been working for some time now, due to #3289 . I've tracked the issue down in transformers utils.py.
It appears that usage of torchscript, is changing type of output from invocations of
GenerationMixinobjects. I'm not sure about the exact reason why is this happening. But the behavior is normalized by simply removingtorchscriptparameter from config.Since purpose of Torchscript is to improve performance, I can guess that merging this fix may cause the pipeline to run a bit slower. But at least it will run.
Proper fix should be implemented in transformers, but I don't have enough experience with the code base to know what to look for.
I'm also reverting #3290 since things should be working now.
Checklist:
conventional commits.
This is an automatic backport of pull request #3307 done by [Mergify](https://mergify.com).