Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add nil check for parsed_body #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2017
Merged

add nil check for parsed_body #353

merged 1 commit into from
Oct 13, 2017

Conversation

ipc103
Copy link
Contributor

@ipc103 ipc103 commented Sep 28, 2017

Closes #339

Sometimes, parsing the decoded body will result in a nil value (i.e. if the decoded_body is "null". Here, we only call [] if the parsed_body is something that can respond to it.

Rather than raising a NoMethodError, the parse_body method will return nil if the decoded_body parses to nil.

@choran choran mentioned this pull request Oct 12, 2017
Closed
choran
choran approved these changes Oct 13, 2017
View reviewed changes
Copy link
Member

@choran choran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Tested it locally and all tests pass
Thanks for submitting this

@choran choran merged commit 042fb37 into intercom:master Oct 13, 2017
@ipc103
Copy link
Contributor Author

ipc103 commented Oct 13, 2017

Awesome - glad I could help!

@ipc103 ipc103 deleted the bugfix-no-method-error-parse-body branch October 13, 2017 14:37
@dorian-davis dorian-davis mentioned this pull request Oct 16, 2017
Closed
@choran choran mentioned this pull request Oct 16, 2017
Closed
@sidonath sidonath mentioned this pull request Apr 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choran choran choran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ipc103 @choran