Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Revert "add nil check for parsed_body" #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Revert "add nil check for parsed_body" #360

wants to merge 3 commits into from

Conversation

dorian-davis
Copy link

Reverts #353

& character in lib/intercom/request.rb seems to be causing issues.

Also reported here: #358

Error log from my test below:

/Users/dori/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/intercom-3.5.20/lib/intercom/request.rb:103:in `parse_body': undefined method `&' for #<Hash:0x007fd5100e1158> (NoMethodError)
	from /Users/dori/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/intercom-3.5.20/lib/intercom/request.rb:72:in `block in execute'
	from /Users/dori/.rbenv/versions/2.3.1/lib/ruby/2.3.0/net/http.rb:853:in `start'
	from /Users/dori/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/intercom-3.5.20/lib/intercom/request.rb:67:in `execute'
	from /Users/dori/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/intercom-3.5.20/lib/intercom/client.rb:113:in `execute_request'
	from /Users/dori/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/intercom-3.5.20/lib/intercom/client.rb:89:in `get'
	from /Users/dori/.rbenv/versions/2.3.1/lib/ruby/gems/2.3.0/gems/intercom-3.5.20/lib/intercom/api_operations/find.rb:13:in `find'
	from test-intercom-ruby.rb:16:in `<main>'

Manually removing & character in lib/intercom/request.rb fixes the issue for me.

@dorian-davis
Copy link
Author

Closing in favour of: #359

Sorry 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dorian-davis