less greedy history fetching.

ivanov · ivanov · commit 681661736e12 · 2014-04-21T12:04:49.000-07:00
set dirty bit on execute, and refetch all data only if dirty bit is set
on 'cursor up'
diff --git a/README.md b/README.md
@@ -303,3 +303,5 @@ TODO / KNOWN ISSUES:
 
     [ ] run completion for "import <tab>" since ipython supports that.
 
+    [ ] implement `get_bipython()` command to inspect bipython as I work on it
+
diff --git a/bipython/__init__.py b/bipython/__init__.py
@@ -677,6 +677,7 @@ def save(self, *args, **kw):
 class URWIDRepl(repl.Repl):
 
     _time_between_redraws = .05 # seconds
+    rl_history_reset = False
 
     def __init__(self, event_loop, palette, interpreter, config):
         repl.Repl.__init__(self, interpreter, config)
@@ -1655,7 +1656,7 @@ def handle_input(self, event):
             self.prompt(more)
             # XXX: fetching all history is expensive, but better than nothing
             # for now
-            self.rl_history = IPythonHistory(self)
+            self.rl_history_reset = True
         elif event == 'ctrl d':
             # ctrl+d on an empty line exits, otherwise deletes
             if self.edit is not None:
@@ -1665,6 +1666,9 @@ def handle_input(self, event):
                     self.main_loop.process_input(['delete'])
         elif urwid.command_map[event] == 'cursor up':
             # "back" from bpython.cli
+            if self.rl_history_reset:
+                self.rl_history = IPythonHistory(self)
+                self.rl_history_reset = False
             self.rl_history.enter(self.edit.get_edit_text())
             self.edit.set_edit_text('')
             self.edit.insert_text(self.rl_history.back()) # + "#previous")

Original file line number	Diff line number	Diff line change
`@@ -303,3 +303,5 @@ TODO / KNOWN ISSUES:`
`303`	`303`
`304`	`304`	`[ ] run completion for "import <tab>" since ipython supports that.`
`305`	`305`
	`306`	+ [ ] implement `get_bipython()` command to inspect bipython as I work on it
	`307`	`+`