Mac: Upgrade SDK and macOS version for legacy build #3066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I'm seeing the active tab being blank here:
|
Member
Author
|
I think it's been like that for a while on modern OS. |
Member
Author
|
I think it's ok to get in then. (Legacy should slowly get deprecated) |
gilgongo
approved these changes
May 17, 2023
Member
gilgongo
left a comment
There was a problem hiding this comment.
Can't see anything else that might be a problem.
Member
Author
|
@pljones please merge if you're ok with that. I believe that it's ok - but I can't really test it. |
pljones
approved these changes
May 19, 2023
Collaborator
pljones
left a comment
There was a problem hiding this comment.
I know nothing at all about macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Updates the SDK to an unsupported higher version for the legacy build. I think, if it builds, it builds and could maybe work. Still, we should slowly deprecate the legacy build (but not suddenly)
I've successfully built it on my repo: https://github.com/ann0see/jamulus/actions/runs/4952341059
Upgrades the legacy build to use the last supported SDK.
CHANGELOG: Mac: The legacy build now uses the macOS 13.1 SDK which is unsupported by Qt 5.9.9. We still provide the legacy build, but from now on consider it as deprecated. You are advised to upgrade your OS.
Context: Fixes an issue?
Fixes: #2773
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
Needs testing by someone with access to an old OS. Or at least someone with macOS. @gilgongo ?
What is missing until this pull request can be merged?
Checklist