Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
π WalkthroughWalkthroughVersion bump from ChangesRelease version bump to 2026.6.11
Estimated code review effortπ― 1 (Trivial) | β±οΈ ~3 minutes Possibly related PRs
Poem
π₯ Pre-merge checks | β 5β Passed checks (5 passed)
βοΈ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis is an automated release PR bumping mise from v2026.6.10 to v2026.6.11, updating version strings across all packaging manifests and vendoring the latest aqua-registry snapshot.
Confidence Score: 5/5Routine release PR β version bumps and CHANGELOG only, plus vendored aqua-registry updates that look well-structured. All changes are mechanical version increments across packaging files and an automated CHANGELOG entry. The aqua-registry vendor diff adds three new packages with proper checksum verification and correct version constraint splits; no logic in the main codebase is touched. No files require special attention. Important Files Changed
Reviews (14): Last reviewed commit: "chore: release 2026.6.11" | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.10 x -- echo |
19.8 Β± 1.0 | 17.7 | 26.3 | 1.00 |
mise x -- echo |
21.1 Β± 3.0 | 18.4 | 39.6 | 1.07 Β± 0.16 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.10 env |
19.5 Β± 0.8 | 17.7 | 23.1 | 1.00 |
mise env |
20.0 Β± 0.9 | 18.3 | 25.2 | 1.02 Β± 0.07 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.10 hook-env |
19.9 Β± 0.8 | 18.1 | 22.9 | 1.00 |
mise hook-env |
20.4 Β± 0.9 | 18.7 | 23.8 | 1.02 Β± 0.06 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.10 ls |
16.8 Β± 0.8 | 15.2 | 20.3 | 1.00 |
mise ls |
17.6 Β± 1.3 | 15.6 | 25.3 | 1.04 Β± 0.09 |
xtasks/test/perf
| Command | mise-2026.6.10 | mise | Variance |
|---|---|---|---|
| install (cached) | 132ms | 137ms | -3% |
| ls (cached) | 58ms | 58ms | +0% |
| bin-paths (cached) | 65ms | 64ms | +1% |
| task-ls (cached) | 124ms | 125ms | +0% |
1e5fdd6 to
3f65eb8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
π€ Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@vendor/aqua-registry/registry.yml`:
- Around line 26768-26784: The ghostscreen version override (for versions <=
0.0.4) explicitly includes a files field specifying the binary name to extract
from the archive. The boo version override (for versions > 0.0.4) is missing
this field for consistency. Locate the boo version override in the registry
configuration and add the files field with the entry name: boo to explicitly
document the expected binary name extracted from the boo archive, matching the
pattern used in the ghostscreen override.
πͺ Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
βΉοΈ Review info
βοΈ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: c608b684-72cb-4ed5-91b4-ddcf5ac1742d
β Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
π Files selected for processing (12)
CHANGELOG.mdCargo.tomlREADME.mdcompletions/_misecompletions/mise.bashcompletions/mise.fishcompletions/mise.ps1default.nixpackaging/rpm/mise.specsnapcraft.yamlvendor/aqua-registry/metadata.jsonvendor/aqua-registry/registry.yml
β Files skipped from review due to trivial changes (7)
- README.md
- packaging/rpm/mise.spec
- vendor/aqua-registry/metadata.json
- completions/mise.ps1
- snapcraft.yaml
- Cargo.toml
- CHANGELOG.md
π§ Files skipped from review as they are similar to previous changes (2)
- default.nix
- completions/_mise
| version_overrides: | ||
| - version_constraint: semver("<= 0.0.4") | ||
| asset: ghostscreen-{{.Arch}}-{{.OS}}.{{.Format}} | ||
| format: tar.gz | ||
| files: | ||
| - name: ghostscreen | ||
| replacements: | ||
| amd64: x86_64 | ||
| arm64: aarch64 | ||
| darwin: macos | ||
| checksum: | ||
| type: github_release | ||
| asset: SHA256SUMS | ||
| algorithm: sha256 | ||
| supported_envs: | ||
| - linux | ||
| - darwin |
There was a problem hiding this comment.
π§© Analysis chain
π Script executed:
#!/bin/bash
# Check coder/boo releases to verify the ghostscreenβboo transition
echo "=== Checking coder/boo releases around version 0.0.4 ==="
gh release list --repo coder/boo --limit 20
echo -e "\n=== Checking release v0.0.4 assets ==="
gh release view v0.0.4 --repo coder/boo --json assets --jq '[.assets[].name]' 2>/dev/null || echo "v0.0.4 not found"
echo -e "\n=== Checking an older release (should have ghostscreen naming) ==="
gh release view --repo coder/boo --json tagName,assets --jq '{tag: .tagName, assets: [.assets[].name]}' 2>/dev/null | head -20
echo -e "\n=== Checking latest release (should have boo naming) ==="
gh release view --repo coder/boo --json tagName,assets --jq '{tag: .tagName, assets: [.assets[].name]}'Repository: jdx/mise
Length of output: 796
π Script executed:
# Check the registry.yml file for coder/boo configuration
# Get context around the provided lines
sed -n '26750,26800p' vendor/aqua-registry/registry.yml | cat -n
# Also check if there's a boo entry after ghostscreen
grep -n "ghostscreen\|^ - name: boo$" vendor/aqua-registry/registry.yml | head -20Repository: jdx/mise
Length of output: 1931
π Script executed:
# Check if the missing files entry is a common pattern or problematic
# Look for similar version_overrides patterns in the registry
grep -A 8 "version_constraint:" vendor/aqua-registry/registry.yml | grep -B 5 "asset: " | head -60Repository: jdx/mise
Length of output: 1716
π Script executed:
# Look specifically at the boo entry and check if there's a pattern for missing files
cat -n vendor/aqua-registry/registry.yml | sed -n '26768,26820p'Repository: jdx/mise
Length of output: 2034
π Script executed:
# Check documentation/patterns for when files entry can be omitted
# Look for other examples where format changes but files entry is missing
rg "version_constraint.*true" vendor/aqua-registry/registry.yml -A 10 | grep -A 10 "format: tar.gz" | head -40Repository: jdx/mise
Length of output: 1027
π Script executed:
# Check if there's documentation on the files field and whether it's required
# Also check the actual coder/boo repository to understand the transition
# Look at coder/boo in the registry again with broader context
cat vendor/aqua-registry/registry.yml | sed -n '26754,26800p' | cat -nRepository: jdx/mise
Length of output: 1688
π Script executed:
# Search for how aqua handles missing files entries
# Look at examples where files is required vs optional
rg "version_overrides" vendor/aqua-registry/registry.yml -A 15 | rg "asset.*boo|files:" | head -30Repository: jdx/mise
Length of output: 526
π Script executed:
# Check if files field is optional by looking for version_overrides without explicit files
# Count entries with and without files
python3 << 'PY'
import yaml
import sys
with open('vendor/aqua-registry/registry.yml', 'r') as f:
data = yaml.safe_load(f)
# Find coder/boo entry
for tool in data:
if isinstance(tool, dict) and tool.get('repo_owner') == 'coder' and tool.get('repo_name') == 'boo':
print("coder/boo configuration:")
print(f"version_overrides count: {len(tool.get('version_overrides', []))}")
for i, override in enumerate(tool.get('version_overrides', [])):
has_files = 'files' in override
vc = override.get('version_constraint')
asset = override.get('asset', 'N/A')
print(f"\nOverride {i+1}:")
print(f" version_constraint: {vc}")
print(f" asset: {asset}")
print(f" has files field: {has_files}")
if has_files:
print(f" files: {override['files']}")
PYRepository: jdx/mise
Length of output: 34
π Script executed:
# Try a simpler approach - check the actual YAML structure
python3 << 'PY'
import yaml
try:
with open('vendor/aqua-registry/registry.yml', 'r') as f:
data = yaml.safe_load(f)
if isinstance(data, list):
for i, tool in enumerate(data):
if isinstance(tool, dict):
owner = tool.get('repo_owner')
name = tool.get('repo_name')
if owner == 'coder' and name == 'boo':
print(f"Found coder/boo at index {i}")
overrides = tool.get('version_overrides', [])
for j, ov in enumerate(overrides):
print(f"\nOverride {j}:")
for key in ['version_constraint', 'asset', 'files', 'format']:
if key in ov:
print(f" {key}: {ov[key]}")
except Exception as e:
print(f"Error: {e}")
import traceback
traceback.print_exc()
PYRepository: jdx/mise
Length of output: 34
π Script executed:
# Direct grep to see the exact structure
grep -A 50 "repo_name: boo" vendor/aqua-registry/registry.yml | head -60Repository: jdx/mise
Length of output: 1631
Add missing files field to the boo version override for consistency.
The version split at 0.0.4 is correctβreleases β€ v0.0.4 use ghostscreen-* assets and releases > v0.0.4 use boo-* assets. Both ranges include SHA256SUMS checksums. However, the first override (ghostscreen) explicitly specifies files: - name: ghostscreen, while the second override (boo) is missing this field. Add files: - name: boo to the second override to explicitly document the expected binary name extracted from the archive.
π€ Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@vendor/aqua-registry/registry.yml` around lines 26768 - 26784, The
ghostscreen version override (for versions <= 0.0.4) explicitly includes a files
field specifying the binary name to extract from the archive. The boo version
override (for versions > 0.0.4) is missing this field for consistency. Locate
the boo version override in the registry configuration and add the files field
with the entry name: boo to explicitly document the expected binary name
extracted from the boo archive, matching the pattern used in the ghostscreen
override.
60ac4a0 to
29c2be7
Compare
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
345e848 to
ddbc3cc
Compare
π Features
π Bug Fixes
π Refactor
π Documentation
π¦οΈ Dependency Updates
π¦ Registry
Chore
COLORTERMenvironment variable by @sschuberth in #10451New Contributors
π¦ Aqua Registry Updates
New Packages (3)
Latias94/mermanbitnami/sealed-secretscoder/booUpdated Packages (1)
suzuki-shunsuke/ghtkn