Codestin Search App

risu729 · 2026-06-15T18:00:11Z

Summary

pass the selected package asset into aqua minisign asset template rendering
fix {{.Asset}}.minisig templates such as jedisct1/minisign 0.12
add a focused regression test for minisign asset rendering

Addresses #10450.

Tests

mise x cargo -- cargo test -p aqua-registry test_minisign_asset_template_uses_package_asset
mise run format (completed, including cargo check)

Summary by CodeRabbit

New Features
- Minisign asset templates now support dynamic, context-aware variable expansion, enabling more flexible configuration of asset paths and naming conventions.
Bug Fixes
- Improved minisign signature verification for GitHub releases by correctly resolving artifact identifiers using actual filenames, enhancing signature verification reliability.
Tests
- Added comprehensive unit tests to validate minisign asset template variable expansion behavior.

coderabbitai · 2026-06-15T18:00:30Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 5228a4f9-9ce0-400f-b400-7d14dc879109

📥 Commits

Reviewing files that changed from the base of the PR and between 5b7ca0d and 999801d.

📒 Files selected for processing (2)

crates/aqua-registry/src/types.rs
src/backend/aqua.rs

📝 Walkthrough

Walkthrough

AquaMinisign gains a new asset(...) method that renders the configured minisign asset template by injecting the already-resolved package asset string into a {{.Asset}} context. The run_minisign_check call site for GithubRelease is updated to pass artifact_filename through to this method, and a unit test validates the template expansion.

Changes

Minisign Asset Template Resolution

Layer / File(s)	Summary
`AquaMinisign::asset()` method and test `crates/aqua-registry/src/types.rs`	Adds `pub fn asset(&self, pkg, package_asset, v, os, arch)` that sets `Asset = package_asset` in the template context and calls `pkg.parse_aqua_str` to render `self.asset`. A unit test asserts `{{.Asset}}` expands from the package's computed asset (e.g., `foo.tar.gz` → `foo.tar.gz.minisig`).
Call site update in `run_minisign_check` `src/backend/aqua.rs`	For `AquaMinisignType::GithubRelease`, `minisign_config.asset(...)` now receives `artifact_filename` as the `package_asset` argument instead of only package+version+OS+arch.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐇 A template with {{.Asset}} so neat,
The minisign file finds its name complete.
The artifact's filename joins the fray,
Rendering .minisig without delay.
Hop hop, the tests confirm it's right! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 57.14% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: enabling minisign asset template rendering with the resolved package asset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-06-15T18:01:32Z

Greptile Summary

This PR fixes aqua minisign asset template rendering by passing the selected package asset into the template context, enabling {{.Asset}} placeholders (e.g., jedisct1/minisign 0.12's {{.Asset}}.minisig) to resolve correctly.

AquaMinisign::asset() gains a package_asset: &str parameter and inserts it into the template context as "Asset", so {{.Asset}} templates in minisign asset paths expand to the actual downloaded artifact filename.
The call site in aqua.rs passes artifact_filename — already available in scope — as the new parameter.
A focused regression test validates that minisign-0.12-linux.tar.gz.minisig is produced when the package asset is minisign-0.12-linux.tar.gz.

Confidence Score: 5/5

Safe to merge — the change is minimal, targeted, and the new regression test covers the exact failure scenario from the linked discussion.

Both changed files are tightly scoped: one adds a parameter to a single function and populates the template context, the other updates the one call site. The artifact_filename passed at the call site is already in scope and represents exactly what {{.Asset}} is meant to expand to. The regression test confirms the before/after behavior. No existing callers are broken — there was only one call site — and the default empty context used elsewhere is unchanged.

No files require special attention.

Important Files Changed

Filename	Overview
crates/aqua-registry/src/types.rs	Adds `package_asset` parameter to `AquaMinisign::asset()`, injects it into the template context as "Asset", and adds a regression test for `{{.Asset}}.minisig` templates.
src/backend/aqua.rs	Updates the single call site of `minisign_config.asset()` to pass `artifact_filename` as the new `package_asset` argument.

_{Reviews (1): Last reviewed commit: "fix(aqua): render minisign asset templat..." | Re-trigger Greptile}

fix(aqua): render minisign asset templates with package asset

999801d

risu729 marked this pull request as ready for review June 15, 2026 18:05

jdx merged commit d43a776 into jdx:main Jun 15, 2026
33 checks passed

mise-en-dev mentioned this pull request Jun 15, 2026

chore: release 2026.6.11 #10446

Merged

risu729 deleted the codex-20260616-032343-ab17d4 branch June 15, 2026 22:56

coderabbitai Bot mentioned this pull request Jun 15, 2026

fix(aqua): support checksum verification fields #10473

Merged

BrewTestBot mentioned this pull request Jun 17, 2026

mise 2026.6.11 Homebrew/homebrew-core#288366

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(aqua): render minisign asset templates with package asset#10462

fix(aqua): render minisign asset templates with package asset#10462
jdx merged 1 commit into
jdx:mainfrom
risu729:codex-20260616-032343-ab17d4

risu729 commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

greptile-apps Bot commented Jun 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

risu729 commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Tests

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

greptile-apps Bot commented Jun 15, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

risu729 commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading