Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Keep Jackson2 behavior to ignore unknown properties#1878

Merged
krisstern merged 1 commit into
jenkinsci:masterfrom
jonesbusy:feature/ignore-unknown-properties
Mar 30, 2026
Merged

Keep Jackson2 behavior to ignore unknown properties#1878
krisstern merged 1 commit into
jenkinsci:masterfrom
jonesbusy:feature/ignore-unknown-properties

Conversation

@jonesbusy

@jonesbusy jonesbusy commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

No test, not harmful since it's the default Jackson2 behavior

Testing done

mvn clean install

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@jonesbusy jonesbusy marked this pull request as ready for review March 30, 2026 10:31
@jonesbusy jonesbusy requested a review from a team as a code owner March 30, 2026 10:31
@jonesbusy

jonesbusy commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Mentionned on #1865 (comment)

But I cannot reproduce with the User model.

But I can reproduce with Namespace model (if I remove the annotation, one of the test fail)

krisstern
krisstern approved these changes Mar 30, 2026
View reviewed changes

@krisstern krisstern left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonesbusy!

@krisstern krisstern merged commit e8f0436 into jenkinsci:master Mar 30, 2026
17 checks passed
@jonesbusy jonesbusy deleted the feature/ignore-unknown-properties branch March 30, 2026 14:15
@krisstern krisstern mentioned this pull request Mar 30, 2026
Merged
6 tasks
jonesbusy pushed a commit to jonesbusy/gitlab-plugin that referenced this pull request Apr 1, 2026
Revert "Keep Jackson2 behavior to ignore unknown properties (jenkinsc…
fac6c2e 
…i#1878)"

This reverts commit e8f0436.
jonesbusy added a commit to jonesbusy/gitlab-plugin that referenced this pull request Apr 1, 2026
@jonesbusy
Revert "Keep Jackson2 behavior to ignore unknown properties (jenkinsc…
107c2db 
…i#1878)"

This reverts commit e8f0436.
krisstern pushed a commit that referenced this pull request Apr 3, 2026
@jonesbusy
Restore Jackson2 (#1882)
1d7f3dc 
* Revert "Jackson3 migration (#1877)"

This reverts commit 5b423b0.

* Revert "Keep Jackson2 behavior to ignore unknown properties (#1878)"

This reverts commit e8f0436.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krisstern krisstern krisstern approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonesbusy @krisstern