Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix legacy context menu items not working#26525

Merged
timja merged 4 commits into
jenkinsci:masterfrom
janfaracik:fix-legacy-menu
Mar 26, 2026
Merged

Fix legacy context menu items not working#26525
timja merged 4 commits into
jenkinsci:masterfrom
janfaracik:fix-legacy-menu

Conversation

@janfaracik
Copy link
Copy Markdown
Member

@janfaracik janfaracik commented Mar 25, 2026

Fixes #26528

Legacy context menu items, e.g. those powered by sidepanel.jelly, lack events, causing them to not respond. There was also a few other issues found when resolving this - they can be seen below:

Testing done

  • Legacy context menu items now work as expected
  • 'Build Now' no longer downloads a file
  • Manage Jenkins -> System breadcrumb now links to sections appropriately
  • No more undefined in menu item class attribute
  • Non relative URLs now link appropriately
  • Some actions were appearing when they shouldn't

Proposed changelog entries

  • Fix legacy context menu items not working

Proposed changelog category

/label web-ui, bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features labels Mar 25, 2026
@MarkEWaite
Copy link
Copy Markdown
Contributor

Thanks for the pull request @janfaracik . Are they not working in the existing user experience or only in the new user experience? If they are broken in the existing user experience, should this be an lts-candidate?

@janfaracik
Copy link
Copy Markdown
Member Author

Thanks for the pull request @janfaracik . Are they not working in the existing user experience or only in the new user experience? If they are broken in the existing user experience, should this be an lts-candidate?

Hey, they are broken in the existing user experience as of 2.556, so just clear of the LTS.

@MarkEWaite
Copy link
Copy Markdown
Contributor

MarkEWaite commented Mar 25, 2026

Hey, they are broken in the existing user experience as of 2.556, so just clear of the LTS.

Thanks! Was the break caused by the upgrade from Spring Security 6 to Spring Security 7? I'm hoping not, but if it was, I'd want to know as soon as possible. I assume not, since the matrix project plugin tests are fixed by reverting pull request:

I think that break is causing the matrix-project plugin tests to fail in the plugin BOM. More details on the failures are available in pull request:

@janfaracik
Copy link
Copy Markdown
Member Author

Hey, they are broken in the existing user experience as of 2.556, so just clear of the LTS.

Thanks! Was the break caused by the upgrade from Spring Security 6 to Spring Security 7? I'm hoping not, but if it was, I'd want to know as soon as possible.

I think that break is causing the matrix-project plugin tests to fail in the plugin BOM. More details on the failures are available in pull request:

Nope! Regrettably I broke it with #11204 - it was a huge change and this slipped under the radar unfortunately.

@daniel-beck daniel-beck added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Mar 25, 2026
Copy link
Copy Markdown
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what all the issues are described in testing done.

I was able to reproduce an issue with breadcrumb jumping on Manage Jenkins which is now fixed.

I clicked around in context menu's and all looks good.

@mawinter69

This comment was marked as resolved.

@mawinter69
Copy link
Copy Markdown
Contributor

mawinter69 commented Mar 25, 2026

On the old build page there is an action to keep the build which does nothing.

And the Edit build information link is doubled

image

@mawinter69

This comment was marked as resolved.

@mawinter69
Copy link
Copy Markdown
Contributor

The duplicate edit build seems to be pipeline specific

@timja
Copy link
Copy Markdown
Member

timja commented Mar 26, 2026

The menu for Manage Jenkins in the header is missing the category headers

Thats fixed in #26523

@github-actions github-actions Bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 26, 2026
@github-actions

This comment was marked as resolved.

@github-actions github-actions Bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Mar 26, 2026
@timja
Copy link
Copy Markdown
Member

timja commented Mar 26, 2026

The duplicate edit build seems to be pipeline specific

Will be resolved with jenkinsci/workflow-job-plugin#746

@timja
Copy link
Copy Markdown
Member

timja commented Mar 26, 2026

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 26, 2026
@timja timja merged commit ac5d3b6 into jenkinsci:master Mar 26, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Context menu with list of jobs not working after upgrade to 2.556

5 participants