Fix legacy context menu items not working#26525
Conversation
a16c60c to
d972e6c
Compare
|
Thanks for the pull request @janfaracik . Are they not working in the existing user experience or only in the new user experience? If they are broken in the existing user experience, should this be an |
Hey, they are broken in the existing user experience as of 2.556, so just clear of the LTS. |
Thanks! Was the break caused by the upgrade from Spring Security 6 to Spring Security 7? I'm hoping not, but if it was, I'd want to know as soon as possible. I assume not, since the matrix project plugin tests are fixed by reverting pull request: I think that break is causing the matrix-project plugin tests to fail in the plugin BOM. More details on the failures are available in pull request: |
Nope! Regrettably I broke it with #11204 - it was a huge change and this slipped under the radar unfortunately. |
timja
left a comment
There was a problem hiding this comment.
Not sure what all the issues are described in testing done.
I was able to reproduce an issue with breadcrumb jumping on Manage Jenkins which is now fixed.
I clicked around in context menu's and all looks good.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
The duplicate edit build seems to be pipeline specific |
Thats fixed in #26523 |
This comment was marked as resolved.
This comment was marked as resolved.
Will be resolved with jenkinsci/workflow-job-plugin#746 |
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |

Fixes #26528
Legacy context menu items, e.g. those powered by
sidepanel.jelly, lackevents, causing them to not respond. There was also a few other issues found when resolving this - they can be seen below:Testing done
undefinedin menu item class attributeProposed changelog entries
Proposed changelog category
/label web-ui, bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.