Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix delete button being missing and actions showing when they shouldn't be#26526

Merged
timja merged 1 commit into
jenkinsci:masterfrom
janfaracik:fix-actions-being-visible
Mar 26, 2026
Merged

Fix delete button being missing and actions showing when they shouldn't be#26526
timja merged 1 commit into
jenkinsci:masterfrom
janfaracik:fix-actions-being-visible

Conversation

@janfaracik
Copy link
Copy Markdown
Member

@janfaracik janfaracik commented Mar 25, 2026

Relates to jenkinsci/bom#6504 (comment)

With thanks to @MarkEWaite and @jglick

delete.jelly had been accidentally removed in #11204 causing the above test to fail. This has been restored in this PR, and whilst doing this PR, I noticed that several actions are visible when they shouldn't be (they should be hidden behind a feature flag).

Testing done

  • Delete is now visible
  • Actions are hidden in legacy UI
  • Actions are visible in experimental UI

Screenshots (UI changes only)

Before

Screenshot 2026-03-25 at 16 59 47

After

image

Experimental UI actions are visible in experimental UI as expected

image

Proposed changelog entries

  • Fix delete button being missing and actions showing when they shouldn't be (regression in 2.556).

Proposed changelog category

/label web-ui, bug

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux @MarkEWaite @jglick

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot Bot added web-ui The PR includes WebUI changes which may need special expertise bug For changelog: Minor bug. Will be listed after features labels Mar 25, 2026
@janfaracik janfaracik force-pushed the fix-actions-being-visible branch from 851fb14 to 83ffe6c Compare March 25, 2026 17:25
@MarkEWaite MarkEWaite added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Mar 25, 2026
Copy link
Copy Markdown
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback. Please see the merge process documentation for more information about the merge process.

/label ready-for-merge

@comment-ops-bot comment-ops-bot Bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 25, 2026
@timja timja merged commit 0fab4d6 into jenkinsci:master Mar 26, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants