Expanding NUS data#189
Merged
Merged
Conversation
…order as well move nus expansion function to proc_base and renamed it to expand_nus
cleanup bruker.py and moved tests from bruker to a new test file for test_proc_base tests for different aqorder and quadrature order added + reformatted
jjhelmus
reviewed
Jan 1, 2023
…ker.py better description for aqorder fixed typo
Closed
Owner
|
@kaustubhmote Thanks for putting this together. Sorry for the long delay in getting this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some functionality to take care of NUS datasets, as discussed in #187 .
Two new functions are introduced:
ng.bruker.read_nuslist: reads nuslist (in bruker format)ng.proc_base.expand_nus: expands nus into a full dataset with zeros at the missing fid locations. This allows arbitrary dimension of the dataset, but generating data > 4D is disallowed by default. It allows an arbitrary acquisition order of indirect dimensions, as well as an arbitrary order for the acquisition of quadrature points. The defaults are tested with data acquired on Bruker spectrometers.The workflow would be something like this for the issue described in #187 :
There are tests added to test these functions with synthetic data.
This is not ready to be merged yet, the documentation of these functions is not yet done. I'll get around to doing that soon, but I'll keep this PR to see if there is any feedback.