Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mehulimukherjee
Copy link
Contributor

@mehulimukherjee mehulimukherjee commented Sep 7, 2025

**This PR removes the old, custom Java serialization support for TestIdentifier. The SerializedForm inner class has been deleted. **

What changed

  1. Deleted the SerializedForm inner class from TestIdentifier.
  2. TestIdentifier keeps implementing Serializable.
  3. Added @SuppressWarnings("serial") to the Set<TestTag> tags, as declared type is Set (not Serializable); actual instances are Serializable.
  4. Removes unused imports
  5. Updated tests:
    • Removed initialVersionCanBeDeserialized() test.
    • Removed the corresponding resource: 'serialized-test-identifier'
    • Added a parameterized Test case currentVersionCanBeSerializedAndDeserialized_withVariousTagCounts(int tagCount) to test the number of tags to be serialized.

I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

@mehulimukherjee
Copy link
Contributor Author

Hi @marcphilipp ,
Making the changes as you suggested.

@marcphilipp marcphilipp merged commit ad0ee62 into junit-team:main Sep 8, 2025
15 checks passed
@marcphilipp
Copy link
Member

Thank you for your contribution, @mehulimukherjee! 👍

@sbrannen sbrannen changed the title #4882 : Removed the TestIdentifier.SerializedForm Remove TestIdentifier.SerializedForm Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove TestIdentifier.SerializedForm to simplify TestIdentifier implementation
2 participants