-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove TestIdentifier.SerializedForm
#4913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
marcphilipp
merged 7 commits into
junit-team:main
from
mehulimukherjee:feature/Remove-TestIdentifier-SerializableForm-4882
Sep 8, 2025
Merged
Remove TestIdentifier.SerializedForm
#4913
marcphilipp
merged 7 commits into
junit-team:main
from
mehulimukherjee:feature/Remove-TestIdentifier-SerializableForm-4882
Sep 8, 2025
+57
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcphilipp
requested changes
Sep 7, 2025
junit-platform-launcher/src/main/java/org/junit/platform/launcher/TestIdentifier.java
Outdated
Show resolved
Hide resolved
platform-tests/src/test/java/org/junit/platform/launcher/TestIdentifierTests.java
Show resolved
Hide resolved
Hi @marcphilipp , |
marcphilipp
requested changes
Sep 8, 2025
junit-platform-launcher/src/main/java/org/junit/platform/launcher/TestIdentifier.java
Outdated
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/TestIdentifier.java
Outdated
Show resolved
Hide resolved
junit-platform-launcher/src/main/java/org/junit/platform/launcher/TestIdentifier.java
Outdated
Show resolved
Hide resolved
platform-tests/src/test/java/org/junit/platform/launcher/TestIdentifierTests.java
Show resolved
Hide resolved
marcphilipp
approved these changes
Sep 8, 2025
Thank you for your contribution, @mehulimukherjee! 👍 |
TestIdentifier.SerializedForm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**This PR removes the old, custom Java serialization support for TestIdentifier. The SerializedForm inner class has been deleted. **
What changed
@SuppressWarnings("serial")
to theSet<TestTag> tags
, as declared type is Set (not Serializable); actual instances are Serializable.initialVersionCanBeDeserialized()
test.currentVersionCanBeSerializedAndDeserialized_withVariousTagCounts(int tagCount)
to test the number of tags to be serialized.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations