Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable more plugins for golangci-lint #17578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Enable more plugins for golangci-lint #17578

wants to merge 1 commit into from

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Aug 25, 2025

Signed-off-by: Arnaud Meukam [email protected]

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign johngmyers for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member Author

ameukam commented Aug 25, 2025

/test pull-kops-verify-golangci-lint

@ameukam ameukam force-pushed the golangci-lint-plugins branch from a7f1cc1 to 657615b Compare August 27, 2025 05:34
@justinsb
Copy link
Member

I do have my concerns about some golangci linters, but these seem to pick up on good things. I think if you want to fix the typos you can do them in this PR (or feed the results into AI!). For removing the unused code, I would typically do that in a different PR, but if they're split into their own commits you could do them in this PR also and we could just go commit-by-commit

@ameukam
Copy link
Member Author

ameukam commented Aug 27, 2025

I do have my concerns about some golangci linters, but these seem to pick up on good things. I think if you want to fix the typos you can do them in this PR (or feed the results into AI!). For removing the unused code, I would typically do that in a different PR, but if they're split into their own commits you could do them in this PR also and we could just go commit-by-commit

That's the plan. add some useful plugins overtime in this PR and solve potential issues in separate PRs.

@ameukam ameukam force-pushed the golangci-lint-plugins branch from 657615b to 62fd5af Compare August 28, 2025 15:01
@ameukam
Copy link
Member Author

ameukam commented Aug 28, 2025

/test pull-kops-verify-golangci-lint

@ameukam ameukam force-pushed the golangci-lint-plugins branch from 62fd5af to 68ae845 Compare August 28, 2025 16:29
@ameukam
Copy link
Member Author

ameukam commented Aug 28, 2025

/test pull-kops-verify-golangci-lint

@ameukam ameukam mentioned this pull request Sep 3, 2025
Merged
@ameukam ameukam force-pushed the golangci-lint-plugins branch from 68ae845 to 1223163 Compare September 3, 2025 15:55
@ameukam
Copy link
Member Author

ameukam commented Sep 3, 2025

/test pull-kops-verify-golangci-lint

@ameukam
Enable more plugins for golangci-lint
47eee1a 
Signed-off-by: Arnaud Meukam <[email protected]>

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam ameukam force-pushed the golangci-lint-plugins branch from 1223163 to 47eee1a Compare September 11, 2025 20:04
@ameukam
Copy link
Member Author

ameukam commented Sep 11, 2025

/test pull-kops-verify-golangci-lint

@k8s-ci-robot
Copy link
Contributor

@ameukam: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-verify-golangci-lint 47eee1a link true /test pull-kops-verify-golangci-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ameukam @k8s-ci-robot @justinsb