Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Golangci-lint v2 fixes: gocritic #17602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 3, 2025
Merged

Golangci-lint v2 fixes: gocritic #17602

merged 12 commits into from
Sep 3, 2025

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Sep 3, 2025

Fixes for failures reported in #17578

Signed-off-by: Arnaud Meukam [email protected]

ameukam added 12 commits September 3, 2025 09:41
@ameukam
Use switch statement
3b4dc81 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Use if statement
8793c6c 
Fix `singleCaseSwitch` error from gocritic

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Assign append result to the same slice
db000b2 
Fix `appendAssign` error from gocritic

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix comment formatting
7e90682 
Fix `commentFormatting` error by gocritic

Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix assignment report by assingOp
bfed831 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix length validation from sloppyLen by gocritic
5e0d25b 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix error report by exitAfterDefer from gocritic
cc049c9 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix error reported by captLocal from gocritic
e0231df 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix error reported by deprecatedComment from gocritic
4e980b8 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix error reported by valSwap from gocritic
26edc0f 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
Fix error reported by unlambda from gocritic
39ce7da 
Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam
make goimports executed
0c743d1 
Signed-off-by: Arnaud Meukam <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from hakman September 3, 2025 11:05
@k8s-ci-robot k8s-ci-robot added area/kops-controller area/nodeup area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/scaleway Issues or PRs related to Scaleway provider area/provider/spotinst Issues or PRs related to spotinst provider labels Sep 3, 2025
@ameukam
Copy link
Member Author

ameukam commented Sep 3, 2025

/retest

@hakman
Copy link
Member

hakman commented Sep 3, 2025

Know failure:
/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

@k8s-ci-robot
Copy link
Contributor

@hakman: Overrode contexts on behalf of hakman: pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

In response to this:

Know failure:
/override pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ameukam
Copy link
Member Author

ameukam commented Sep 3, 2025

cc @rifelpet @justinsb

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit 95516f3 into kubernetes:master Sep 3, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

@hakman hakman Awaiting requested review from hakman

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/kops-controller area/nodeup area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/gcp Issues or PRs related to gcp provider area/provider/hetzner Issues or PRs related to Hetzner provider area/provider/scaleway Issues or PRs related to Scaleway provider area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ameukam @hakman @k8s-ci-robot @rifelpet