-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat: add CPU and memory resource configuration for AWS Load Balancer Controller #17608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add CPU and memory resource configuration for AWS Load Balancer Controller #17608
Conversation
Hi @ana-aguilar7. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/test pull-kops-verify-generated |
777812d
to
17a13f0
Compare
/retest-required |
/retest |
/test pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons |
@ana-aguilar7 please ignore that test for now. |
@ana-aguilar7 instead of creating a new integration test, could you add the new options to t the following tests?
|
/test pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons |
/retest |
@ana-aguilar7 Please rebase, needed to grab the latest change to pass the |
91eab65
to
ac725cf
Compare
@ana-aguilar7: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@ana-aguilar7 I think you are still missing a few files from |
Context
Adds support for configuring CPU and memory resources for the AWS Load Balancer Controller addon.