Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

ana-aguilar7
Copy link
Contributor

Context

Adds support for configuring CPU and memory resources for the AWS Load Balancer Controller addon.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ana-aguilar7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rifelpet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ameukam
Copy link
Member

ameukam commented Sep 11, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2025
@ana-aguilar7
Copy link
Contributor Author

/test pull-kops-verify-generated

@ana-aguilar7 ana-aguilar7 force-pushed the add-config-cpu-and-memory branch from 777812d to 17a13f0 Compare September 11, 2025 18:17
@ana-aguilar7
Copy link
Contributor Author

/retest-required

@ana-aguilar7
Copy link
Contributor Author

/retest

@ana-aguilar7
Copy link
Contributor Author

/test pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

@hakman
Copy link
Member

hakman commented Sep 12, 2025

@ana-aguilar7 please ignore that test for now.

@hakman
Copy link
Member

hakman commented Sep 12, 2025

@ana-aguilar7 instead of creating a new integration test, could you add the new options to t the following tests?

many-addons-ccm
many-addons-ccm-irsa

@hakman
Copy link
Member

hakman commented Sep 12, 2025

/test pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons

@kubernetes kubernetes deleted a comment from k8s-ci-robot Sep 12, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2025
@ana-aguilar7
Copy link
Contributor Author

/retest

@hakman hakman requested review from ameukam and removed request for zetaab September 16, 2025 06:29
@hakman
Copy link
Member

hakman commented Sep 16, 2025

@ana-aguilar7 Please rebase, needed to grab the latest change to pass the netlify tests.
Also, you need to run make apimachinery crds and add the output to the PR.
Other than that, this LGTM.

@ana-aguilar7 ana-aguilar7 force-pushed the add-config-cpu-and-memory branch from 91eab65 to ac725cf Compare September 18, 2025 00:52
@k8s-ci-robot
Copy link
Contributor

@ana-aguilar7: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kops-test ac725cf link true /test pull-kops-test
pull-kops-e2e-k8s-gce-ipalias ac725cf link true /test pull-kops-e2e-k8s-gce-ipalias

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Sep 20, 2025

@ana-aguilar7 I think you are still missing a few files from hack/update-expected.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants