Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add CPU and memory resource configuration for AWS Load Balancer Controller #17608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

feat: add CPU and memory resource configuration for AWS Load Balancer Controller #17608

merged 1 commit into from
Sep 25, 2025
+186 −14

Conversation

ana-aguilar7
Copy link
Contributor

Context

Adds support for configuring CPU and memory resources for the AWS Load Balancer Controller addon.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @ana-aguilar7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ameukam
Copy link
Member

ameukam commented Sep 11, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 11, 2025
@ana-aguilar7
Copy link
Contributor Author

/test pull-kops-verify-generated

@ana-aguilar7 ana-aguilar7 force-pushed the add-config-cpu-and-memory branch from 777812d to 17a13f0 Compare September 11, 2025 18:17
@ana-aguilar7
Copy link
Contributor Author

/retest-required

@ana-aguilar7
Copy link
Contributor Author

/retest

@ana-aguilar7
Copy link
Contributor Author

/test pull-kops-e2e-aws-upgrade-k133-ko133-to-klatest-kolatest-many-addons

@hakman
Copy link
Member

hakman commented Sep 12, 2025

@ana-aguilar7 please ignore that test for now.

@hakman
Copy link
Member

hakman commented Sep 12, 2025

@ana-aguilar7 instead of creating a new integration test, could you add the new options to t the following tests?

many-addons-ccm
many-addons-ccm-irsa

@hakman
Copy link
Member

hakman commented Sep 12, 2025

/test pull-kops-e2e-aws-upgrade-k133-ko133-to-kstable-kolatest-many-addons

@kubernetes kubernetes deleted a comment from k8s-ci-robot Sep 12, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 15, 2025
@ana-aguilar7
Copy link
Contributor Author

/retest

@hakman hakman requested review from ameukam and removed request for zetaab September 16, 2025 06:29
@hakman
Copy link
Member

hakman commented Sep 16, 2025 •
edited
Loading

@ana-aguilar7 Please rebase, needed to grab the latest change to pass the netlify tests.
Also, you need to run make apimachinery crds and add the output to the PR.
Other than that, this LGTM.

@ana-aguilar7 ana-aguilar7 force-pushed the add-config-cpu-and-memory branch from 91eab65 to ac725cf Compare September 18, 2025 00:52
@hakman
Copy link
Member

hakman commented Sep 20, 2025

@ana-aguilar7 I think you are still missing a few files from hack/update-expected.sh.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2025
@hakman
Copy link
Member

hakman commented Sep 24, 2025

@ana-aguilar7 looks like all the tests passed, good job! 🙁
Would you mind also squashing the commits before merging?
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@ana-aguilar7
feat: Add CPU and memory resource configuration for AWS Load Balancer…
caf7bb2 
… Controller

feat: Add CPU and memory resource configuration for AWS Load Balancer Controller

chore: remove unused tests

chore: update tests with CPU/memory configurations

feat: update integration tests for CPU and memory configuration in addons
@ana-aguilar7 ana-aguilar7 force-pushed the add-config-cpu-and-memory branch from ebf4b61 to caf7bb2 Compare September 24, 2025 20:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@ana-aguilar7
Copy link
Contributor Author

@ana-aguilar7 looks like all the tests passed, good job! 🙁 Would you mind also squashing the commits before merging? /lgtm

Done, commits squashed. Thanks for your patience! 🙏

@hakman
Copy link
Member

hakman commented Sep 24, 2025

Thank you for your contribution @ana-aguilar7!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
@hakman
Copy link
Member

hakman commented Sep 24, 2025

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 79b3672 into kubernetes:master Sep 25, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman Awaiting requested review from hakman

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@hakman hakman

@ana-aguilar7 ana-aguilar7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ana-aguilar7 @k8s-ci-robot @ameukam @hakman @k8s-triage-robot