Fix cadvisor_unsupported and the crossbuild#35817
Merged
Merged
Conversation
Member
Author
|
@k8s-bot build this |
Contributor
|
/lgtm |
Contributor
|
I merged this into 1.4 already to get the release done today along with #35136 so removing the cherry-pick candidate label |
vishh
reviewed
Oct 28, 2016
| var _ Interface = new(cadvisorUnsupported) | ||
|
|
||
| func New(port uint, runtime string) (Interface, error) { | ||
| func New(port uint, runtime string, rootPath string) (Interface, error) { |
Contributor
There was a problem hiding this comment.
nit: these input arguments can be ignored. Use _ instead :)
Member
Author
There was a problem hiding this comment.
yeah, sure, but didn't want to break the pattern :)
Contributor
|
Jenkins GCE Node e2e failed for commit 00fda67. Full PR test history. The magic incantation to run this job again is |
Contributor
|
@k8s-bot node e2e test this |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
jessfraz
added a commit
to jessfraz/kubernetes
that referenced
this pull request
Nov 1, 2016
…herry-pick-of-#35136-kubernetes#35817-origin-release-1.4" This reverts commit 7964708, reversing changes made to b7ad318.
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ck-of-#35136-kubernetes#35817-origin-release-1.4 Automated cherry pick of kubernetes#35136 kubernetes#35817
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a bug in the
cadvisor_unsupported.gocode.Fixes #35735
Introduced by: #35136
We should consider to cherrypick this as #35136 also was cherrypicked
cc @kubernetes/sig-testing @vishh @dashpole @jessfraz
This change is