Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update generated for 2017 #39342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2017
Merged

Update generated for 2017 #39342

merged 2 commits into from
Jan 2, 2017

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Jan 1, 2017 •
edited
Loading

What this PR does / why we need it: repeat of #19222 for 2017. Some year we'll properly fix this.

Which issue this PR fixes: fixes ci-kubernetes-verify-master build

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 1, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 1, 2017
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 38c924dadfa11012bb0da04a4b15123c92cdfe33. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@smarterclayton
Copy link
Contributor

All of the generated code needs to be recreated.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 38c924dadfa11012bb0da04a4b15123c92cdfe33. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@thockin
Copy link
Member

thockin commented Jan 2, 2017

This is really dumb. Generated code should not have the copyright changed. I'll file a gengo bug. Not sure how to fix it.

@wojtek-t wojtek-t mentioned this pull request Jan 2, 2017
Closed
@wojtek-t wojtek-t self-assigned this Jan 2, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jan 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Jan 2, 2017

Will merge on green (as submit queue is blocked)

@wojtek-t
Copy link
Member

wojtek-t commented Jan 2, 2017

Merging to fix the build.

@wojtek-t wojtek-t merged commit 5e9f39b into kubernetes:master Jan 2, 2017
@ixdy
Copy link
Member Author

ixdy commented Jan 2, 2017

@wojtek-t thanks!
@smarterclayton I ran hack/update-all.sh -v -a but apparently it missed a file.
@thockin I agree that this is bad. I'm hoping that maybe the generated code situation will be a in a better place by 2018...

Frustratingly, the verify-boilerplate script has been copied into a number of other repos (at least contrib and test-infra, and maybe others), so we'll probably need to fix it in all of those, too.

@wojtek-t wojtek-t mentioned this pull request Jan 2, 2017
Merged
@spxtr
Copy link
Contributor

spxtr commented Jan 2, 2017

Frustratingly, the verify-boilerplate script has been copied into a number of other repos (at least contrib and test-infra, and maybe others), so we'll probably need to fix it in all of those, too.

I think that's the goal of kubernetes/repo-infra.

@spxtr spxtr mentioned this pull request Jan 2, 2017
Merged
@krzyzacy
Copy link
Member

krzyzacy commented Jan 3, 2017

Really?! I thought we support ( or we currently have ) multiple years in the boilerplate ( at least in test-infra ).

@spxtr
Copy link
Contributor

spxtr commented Jan 3, 2017

Really?! I thought we support ( or we currently have ) multiple years in the boilerplate ( at least in test-infra ).

We do, the problem is that we verify that generated code that we check in matches what you would get if you generate it from scratch, but the checked in code had 2016 in the boilerplate.

@freehan freehan mentioned this pull request Jan 3, 2017
Closed
@saad-ali saad-ali mentioned this pull request Jan 3, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jan 4, 2017
Merge pull request #39392 from saad-ali/fixVerifyGeneratedFilesFor2017
215832b 
Automatic merge from submit-queue

Update generated files for 2017 to fix broken `ci-kubernetes-verify-release-1.5`

Fixes [broken](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-verify-release-1.5/1848/) `ci-kubernetes-verify-release-1.5`

Similar to #39342 except for 1.5 branch.
@jessfraz jessfraz mentioned this pull request Jan 4, 2017
Merged
@ixdy ixdy mentioned this pull request Jan 11, 2017
Merged
fabioy added a commit that referenced this pull request Jan 12, 2017
@fabioy
Merge pull request #39765 from ixdy/automated-cherry-pick-of-#39342-#…
6998c71 
…39074-upstream-release-1.3

Automated cherry pick of #39342 #39074 #38196
@liggitt liggitt mentioned this pull request Apr 14, 2017
Closed
@cblecker cblecker mentioned this pull request Jan 2, 2018
Closed
@ixdy ixdy deleted the happy-new-year branch May 15, 2018 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

@wojtek-t wojtek-t

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ixdy @k8s-reviewable @k8s-ci-robot @smarterclayton @thockin @wojtek-t @spxtr @krzyzacy @nikhiljindal @k8s-github-robot