A loop with a score function is scary to me. What do you think about building a map and expressing priority based on execution order? Something similar to GetHostIP() in the kubelet.

I think this code should be functionally identical to that code, but without the temporary map.

GetHostIP is much clearer, so I can do that. It sounds like maybe we are going to remove this check entirely though, depending on when #7092 lands. (Some initial discussion in #7115)

Yeah #7092 has some interesting implications. Does #7182 unbreak AWS for now?

I would generally assume that #7092 is aspirational until someone is signed up to work on it.

#7182 does/should unbreak AWS for now - it would be good to get that merged!

AWS needs this and #7115 if I wanted to change the node name to the EC2 instance id, which would be great to do long-term. In #7182 I put out the fire, so this can wait until #7092 is implemented.

I don't suppose there's a different reason to merge this and/or #7115? @cjcullen you mentioned you were also looking at this (for a different reason, I guess)

Similar reason... It would be nice to remove the requirement that the master must have DNS cname record entries for nodes that match their k8s names (or the value passed in with --hostname_override). We have that Addresses field on the nodes which I think was added for exactly this type of thing.

I'm interested to see where #7092 goes, but as long as we have Master->Kubelet communication, I think it would be useful to get this change in. It'll make this use case cleaner, and hopefully guide new code away from using Node.Name as a resolvable address.