Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added Hover to Views Menu in Web UI #8548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2015
Merged

Added Hover to Views Menu in Web UI #8548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,935 changes: 973 additions & 962 deletions pkg/ui/datafile.go
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion third_party/ui/bower_components/angular-material/angular-material.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7709,7 +7709,10 @@ function SelectProvider($$interimElementProvider) {
var focusedNode = centeredNode || optionNodes[0];
if (focusedNode) {
opts.focusedNode = focusedNode;
focusedNode.focus();
// This is commented out to fix an issue where the first option remains in focus
// even after you mouseover to a different option.
// It is fixed in the compiled source and is here for reference.
// focusedNode.focus();
}

if (isScrollable) {
Expand Down
2 changes: 1 addition & 1 deletion third_party/ui/bower_components/angular-material/angular-material.min.js
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 5 additions & 2 deletions third_party/ui/bower_components/angular-material/modules/closure/select/select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ function SelectProvider($$interimElementProvider) {
contentEl: element.find('md-content'),
backdrop: opts.hasBackdrop && angular.element('<md-backdrop class="md-select-backdrop">')
});

var optionNodes = [];

configureAria();
Expand Down Expand Up @@ -757,7 +757,10 @@ function SelectProvider($$interimElementProvider) {
var focusedNode = centeredNode || optionNodes[0];
if (focusedNode) {
opts.focusedNode = focusedNode;
focusedNode.focus();
// This is commented out to fix an issue where the first option remains in focus
// even after you mouseover to a different option.
// It is fixed in the compiled source and is here for reference.
// focusedNode.focus();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out? Will it ever be uncommented? What's the TODO here? (and elsewhere)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgrant0607 This is commented out to fix an issue in the angular directive where the first option remains in focus, even after you mouseover to a different option. It is fixed in the compiled source and is there for reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert it to an explanatory comment rather than leaving it as commented-out code.

}

if (isScrollable) {
Expand Down
11 changes: 11 additions & 0 deletions www/app/assets/css/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,17 @@ md-toolbar h1 {
vertical-align: middle;
padding: 2px;
}
md-select-menu.md-default-theme md-option:focus:not([selected]) {
background: #eeeeee;
}
md-select-menu md-option {
transition: box-shadow 0.4s cubic-bezier(0.25, 0.8, 0.25, 1), background-color 0.4s cubic-bezier(0.25, 0.8, 0.25, 1), -webkit-transform 0.4s cubic-bezier(0.25, 0.8, 0.25, 1);
transition: box-shadow 0.4s cubic-bezier(0.25, 0.8, 0.25, 1), background-color 0.4s cubic-bezier(0.25, 0.8, 0.25, 1), transform 0.4s cubic-bezier(0.25, 0.8, 0.25, 1);
}
md-select-menu md-option:not([disabled]):hover,
md-select-menu md-option:not([disabled]):focus {
background-color: rgba(158, 158, 158, 0.2);
}
.dashboard .body-wrapper {
padding: 25px;
}
Expand Down
Loading