Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

yliaog
Copy link
Contributor

@yliaog yliaog commented Jan 31, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

rebase from master branch

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


tomplus and others added 30 commits September 18, 2018 22:12
fix: read config data with bytes (python3)
Replace base64.decodestring for base64.standard_b64decode
*Update unit tests to use ConfigNode() instead of dict()
…onal-values

ExecProvider errors when parsing null values
Pep8 has been renamed to pycodestyle
Refresh GCP tokens on retrieval by overriding client config method.
The watch code reset the version to the last found in the
response.
When you first list existing objects and then start watching from that
resource version the existing versions are older than the version you
wanted and the watch starts from the wrong version after the first
restart.
This leads to for example already deleted objects ending in the stream
again.

Fix this by setting the minimum resource version to reset from to the
input resource version. As long as k8s returns all objects in order in
the watch this should work.
We cannot use the integer value of the resource version to order it as
one should be treat the value as opaque.

Closes kubernetes-client#700
…reset

fix watching with a specified resource version
@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 31, 2022
@k8s-ci-robot k8s-ci-robot requested a review from roycaihw January 31, 2022 19:37
@linux-foundation-easycla
Copy link

CLA Not Signed

  • ❌ The commit (ebb49d0 ,13ff5184ac43c0bffa813bbba4fca04d610c45d7 ,69570ac7088e78edab2d41809a86be2cd9e6e2fd ,a4f249b48a467e8c605c09a944a14d6eb6e62b9a) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.
  • - Moshe Shitrit The commit (7199c14 ,0c662bb33dfb49236ca4c68b81d426d8948da224 ,10db259908b025cfdcbba28c455de9bac54e16aa ,2c9ddf94b6614c9f16a234de0ce69e01270466c6 ,8e4c5ebe4f1aa9d1889b7c31de1b1fd600db9744 ,9bce8696ffb10e30757e93e72d5c4970d5144c16 ,0395a107185cef66592dfd26dbb8118179d272c4 ,34b8304d5fe0b95df8b9968f766cf9e8598e778a ,0a5b04feead64f73ae042665251e3aef5e35f84e ,cf2f312fd06debceee9a06afe2eefccbd2649f1e ,b5aa2dd3718949a066cf1f01927ef4432f2e4dcc ,698299af9d3229d02624c4e6bb87e076bdcea000 ,6d1c8d3713057e87d973d853b36373c06901d092) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.
  • - aagten The commit (d47030a) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 31, 2022
@yliaog
Copy link
Contributor Author

yliaog commented Jan 31, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 31, 2022
@k8s-ci-robot
Copy link
Contributor

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yliaog
Copy link
Contributor Author

yliaog commented Jan 31, 2022

/assign @roycaihw

@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2022
@roycaihw roycaihw merged commit 873e8fd into kubernetes-client:release-22.0 Jan 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.