-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix for #187 failure when using RFC 6902 json-patch operation #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## release-2.0 #205 +/- ##
============================================
Coverage 94.56% 94.56%
============================================
Files 9 9
Lines 681 681
============================================
Hits 644 644
Misses 37 37 Continue to review full report at Codecov.
|
CLA completed. |
LGTM 👍 |
LGTM. Thanks. nit: Can you add an entry in CHANGELOG.md? |
I'm happy to add the changelog entry. It seems this is a bugfix which would also be good in the 1.0 branch for kubernetes 1.5 users. Would you prefer a separate PR for that? |
There is no need for a separate PR for that. We can cherry-pick this PR into 1.0 release after it got merged. |
Great, thank you! |
I just realize this PR is sent against release-2.0. I will move it to master. We should always merge these into master first. |
…pstream-master Automated cherry pick of #205
…pstream-release-1.0 Automated cherry pick of #205
…ates Accept client certificates from an authn/authz plugin
My solution to the issue assumes a body containing a JSON array to be a RFC 6902 'json-patch' operation because this RFC requires an array of operations. The existing code already assumes the use of 'strategic-merge-patch' (Kubernetes preferred) instead of the RFC 7386 'merge-patch', so I left that behavior as is.