Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix for #187 failure when using RFC 6902 json-patch operation #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 1, 2017

Conversation

bsherman
Copy link

My solution to the issue assumes a body containing a JSON array to be a RFC 6902 'json-patch' operation because this RFC requires an array of operations. The existing code already assumes the use of 'strategic-merge-patch' (Kubernetes preferred) instead of the RFC 7386 'merge-patch', so I left that behavior as is.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 28, 2017
@codecov-io
Copy link

codecov-io commented Apr 28, 2017

Codecov Report

Merging #205 into release-2.0 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-2.0     #205   +/-   ##
============================================
  Coverage        94.56%   94.56%           
============================================
  Files                9        9           
  Lines              681      681           
============================================
  Hits               644      644           
  Misses              37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d943b...e4c5cc7. Read the comment docs.

@bsherman
Copy link
Author

CLA completed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 28, 2017
@dims
Copy link
Collaborator

dims commented Apr 30, 2017

LGTM 👍

@mbohlool
Copy link
Contributor

LGTM. Thanks. nit: Can you add an entry in CHANGELOG.md?

@bsherman
Copy link
Author

bsherman commented May 1, 2017

I'm happy to add the changelog entry. It seems this is a bugfix which would also be good in the 1.0 branch for kubernetes 1.5 users. Would you prefer a separate PR for that?

@mbohlool
Copy link
Contributor

mbohlool commented May 1, 2017

There is no need for a separate PR for that. We can cherry-pick this PR into 1.0 release after it got merged.

@mbohlool mbohlool merged commit ccc9809 into kubernetes-client:release-2.0 May 1, 2017
@bsherman
Copy link
Author

bsherman commented May 1, 2017

Great, thank you!

@mbohlool
Copy link
Contributor

mbohlool commented May 4, 2017

I just realize this PR is sent against release-2.0. I will move it to master. We should always merge these into master first.

mbohlool added a commit that referenced this pull request May 4, 2017
mbohlool added a commit that referenced this pull request May 4, 2017
…pstream-release-1.0

Automated cherry pick of #205
yliaog pushed a commit to yliaog/client-python that referenced this pull request Jan 8, 2022
…ates

Accept client certificates from an authn/authz plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants