Use py.test instead of nosetests for better problem reporting #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6623962 to
1644082
Compare
mbohlool
reviewed
Jul 5, 2017
| @@ -22,12 +22,12 @@ commands = | |||
| [testenv:py27-functional] | |||
| commands = | |||
| python -V | |||
| {toxinidir}/scripts/kube-init.sh nosetests -v [] | |||
There was a problem hiding this comment.
Why only these two e2e tests? what about py36-functional and non-e2e tests? can we use py.test for those too?
There was a problem hiding this comment.
Switched them all except for coverage. Let's wait on that one to see if it runs into trouble
mbohlool
reviewed
Jul 5, 2017
| @@ -1,5 +1,6 @@ | |||
| coverage>=4.0.3 | |||
| nose>=1.3.7 | |||
There was a problem hiding this comment.
yes, testenv:coverage still uses both coverage and nose.
There was a problem hiding this comment.
OK. this looks good, can you rebase your branch so I can merge it? (the branch is out of date).
nosetests output is not very useful for diagnosing issues when running in travis. Let us switch to py.test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nosetests output is not very useful for diagnosing issues when
running in travis. Let us switch to py.test