Rename parameter async into async_req to support Python 3.7 #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as Python 3.7 treats async as a reserved keyword.
also update README for v7 release
|
/lgtm |
brendandburns
pushed a commit
to brendandburns/python
that referenced
this pull request
Jul 23, 2018
Rename parameter async into async_req to support Python 3.7
ojarjur
added a commit
to ojarjur/tf-operator
that referenced
this pull request
Aug 21, 2018
The Python Kubernetes client [recently changed](kubernetes-client/python#568) the name of the `async` keyword parameter in its API to `async_req`. This change makes the corresponding change to our calls to that API, which is necessary for the tf-operator code to work against the latest version of the Kubernetes client code.
k8s-ci-robot
pushed a commit
to kubeflow/trainer
that referenced
this pull request
Aug 23, 2018
* Rename the `async` keyword argument to `async_req` The Python Kubernetes client [recently changed](kubernetes-client/python#568) the name of the `async` keyword parameter in its API to `async_req`. This change makes the corresponding change to our calls to that API, which is necessary for the tf-operator code to work against the latest version of the Kubernetes client code. * Update kubernetes requirement to >= 7.0.0 This also updates the outdated dependencies in the Pipfile.lock file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as Python 3.7 treats
asyncas a reserved keyword. Add Action Required entry in CHANGELOG.Also update README for v7 branch release.
/cc @yliaog