Graduate TopologyAwareScheduling to Beta. #6830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
014693d to
c97af4c
Compare
55636ca to
447a53b
Compare
mimowo
reviewed
Sep 15, 2025
There was a problem hiding this comment.
/lgtm
/approve
Leaving final tagging to @tenzen-y.
/hold
I'm still working on #4041, but I wouldn't like to block on it, because:
- I'm not convinced eliminating the label is worth it, because it means we need to index, and the indexer can throw errors due to lookups to additional objects on the path.
- We can still deprecate the label and drop while in Beta. Beta is not "written in stone API"
- Dropping the label is easy, because if replaced with index, then the change is fully backwards-compatible.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mbobrovskyi, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: fe48bfef5e555cda7210dcd82f91e278a9b769b9
|
|
Are there any objections to merge this PR? |
|
seems like it already requires rebasing |
447a53b to
486d7ec
Compare
Rebased. |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 48908fb999e301d0ef1b0989f06b377e75f7f094
|
|
/release-note-edit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
Graduate TopologyAwareScheduling to Beta.
Which issue(s) this PR fixes:
Fixes #3450
Special notes for your reviewer:
Does this PR introduce a user-facing change?