Thanks to visit codestin.com
Credit goes to github.com

Skip to content

TAS: stop injecting the TAS Label into Pods #6895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2025
Merged

TAS: stop injecting the TAS Label into Pods #6895

merged 1 commit into from
Sep 18, 2025

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Sep 17, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #3450

Special notes for your reviewer:

Does this PR introduce a user-facing change?

TAS: stop setting the "kueue.x-k8s.io/tas" label on Pods. 

In case the implicit TAS mode is used, then the `kueue.x-k8s.io/podset-unconstrained-topology=true` annotation
is set on Pods.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2025
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit ad08a56
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/68cbfc940630a6000862c1f4

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Sep 17, 2025

/assign @tenzen-y

@mimowo mimowo mentioned this pull request Sep 17, 2025
Closed
@mimowo
Copy link
Contributor Author

mimowo commented Sep 17, 2025

/test pull-kueue-test-e2e-main-1-33
infra

@mimowo mimowo mentioned this pull request Sep 18, 2025
Merged
@mimowo
Copy link
Contributor Author

mimowo commented Sep 18, 2025

cc @PBundyra @gabesaba could you give it a pass?

@mimowo
Copy link
Contributor Author

mimowo commented Sep 18, 2025

/test pull-kueue-test-e2e-main-1-31
/test pull-kueue-test-e2e-multikueue-main
known flakes

@mimowo
Copy link
Contributor Author

mimowo commented Sep 18, 2025

/test pull-kueue-test-e2e-multikueue-main

tenzen-y
tenzen-y reviewed Sep 18, 2025
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I left follow-up comments.

/lgtm
/approve

pkg/util/tas/tas.go
if _, ok := pod.Annotations[kueuealpha.PodSetUnconstrainedTopologyAnnotation]; ok {
return true
}
// TODO: remove after 0.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open a dedicated issue for this follow-up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened: #6911

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 42daba1c548686a7e4f10eae9e9ef9203f3d97e4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mimowo
Copy link
Contributor Author

mimowo commented Sep 18, 2025

/hold
let me address them streight, maybe it is not rebased

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2025
@tenzen-y
Copy link
Member

We may also think if we drop the label entirely or just deprecate, to handle gracefully upgrade for users from TAS Alpha to TAS Beta. We have some adoption of Alpha, so maybe safer to keep label for one-two releases anyway, wdyt?

Based on our offline discussion, we decided to keep the TAS label for 2 minor releases since immediate removal of this label could cause disruption in the existing user environment.

Indeed, TAS is alpha features. So, we do not have any commitment to keep backward compatibility for the alpha feature.
But, keeping this label is very trivial work, but the advantages for existing users are very high.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2025
@mimowo
Copy link
Contributor Author

mimowo commented Sep 18, 2025

/unhold
Just pushed to rename "kueuealpha" as "kueue".

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2025
@tenzen-y
Copy link
Member

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7d2358b7640ac1021e5863fec4e0dee9b4c8fcc

@k8s-ci-robot k8s-ci-robot merged commit e4fb8ef into kubernetes-sigs:main Sep 18, 2025
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.14 milestone Sep 18, 2025
@mimowo mimowo mentioned this pull request Sep 30, 2025
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@tenzen-y tenzen-y

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@mimowo @k8s-ci-robot @tenzen-y