Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

nimarb
Copy link
Contributor

@nimarb nimarb commented Aug 25, 2025

Important

Moves observation type override logic for Python SDK <= 3.3.0 to ObservationTypeMapper, centralizing mapping logic.

  • Behavior:
    • Moves observation type override logic for Python SDK <= 3.3.0 from OtelIngestionProcessor to ObservationTypeMapper.
    • ObservationTypeMapperRegistry now handles the override using a CustomAttributeMapper with priority 0.
  • Functions:
    • Updates canMap() and mapToObservationType() in ObservationTypeMapper to accept resourceAttributes and scopeData.
    • Removes observation type override logic from processSpan() in OtelIngestionProcessor.
  • Tests:
    • Updates otelMapping.servertest.ts to test the new mapping logic for Python SDK <= 3.3.0.

This description was created by Ellipsis for 01a8498. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Aug 25, 2025
@nimarb nimarb enabled auto-merge September 2, 2025 12:47
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 2, 2025
@nimarb nimarb added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 816abfb Sep 2, 2025
29 checks passed
@nimarb nimarb deleted the nimar/obs-type-mapper-python330-bugfix-clean branch September 2, 2025 13:21
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 2, 2025
gongxh13 pushed a commit to gongxh13/langfuse that referenced this pull request Sep 3, 2025
* chore: move obsevation type setting override to mapper

* simplify mapper

* map nicer

* simplify
nimarb added a commit that referenced this pull request Sep 3, 2025
* chore: move obsevation type setting override to mapper

* simplify mapper

* map nicer

* simplify
nimarb added a commit that referenced this pull request Sep 4, 2025
* chore: upgrade to nextjs v15

* update mui x-tree-view

* upgrade next themese

* update react-day-picker react-resizable-panels

* update sonner

* update next-query-params

* update react-email

* upgrade types react in shared

* upgrade next in ee

* next config remove now stable hook

* fix next-themes not exporting prop types directly anymore

* fix mui-x-tree peer dependency

* fix markdown viewer (ugly) to get around stricter typing

* add config to oltp protobus for nextjs15

* HACK: temp circumvent ApiRouteConfig typing

* TEMP: try nextjs15 workaround for SCIM

* try more ram

* not experimental no more

* moar memory

* update memory

* over 8000

* fix turbopack issues

* fix dockerfile

* default to turbo in web

* accept warnings for now

* cleanup

* cleanup

* remove tiktoken stuff

* chore: move obsevation type setting override to mapper (#8714)

* chore: move obsevation type setting override to mapper

* simplify mapper

* map nicer

* simplify

* feat(single-trace): add copy button on value cell of json view (#8871)

* fix: use leftUTF8 for input/output truncation on clickhouse (#8869)

* chose: use leftUTF8 for input/output truncation on clickhouse

* chore: skip truncation linebreak

* fix(trace-detail): guard against zero latency in trace tree (#8874)

fix(trace-detail): guard against zero latency

* chore: patch flaky trace repository test (#8870)

* chore: bump dd-trace to 5.65.0 (#8882)

* fix(prompts): subfolders hiding prompts (#8876)

* fix(prompts): subfolders hiding prompts

* Update web/src/features/prompts/server/routers/promptRouter.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix da lint!

* fix

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix(trace-single-ui): fix unavailable ref (#8883)

* fix(trace-single-ui): fix unavailable ref

* really fix it

* chore: release v3.106.4

* chore: add env note to review.md (#8888)

* feat(table-ui): filter score columns to show score only if has value for given table (#8865)

* feat(table-ui): filter score columns to show score only if has value for given table

* chore: refactor analytics

* chore: include dataset id in filter condition for DRI scores

* chore: fix tests

* chore: await data

* fixup-remove: upgrade to nextjs v15 (#8795)

* chore: simplify query

* chore: remove getRunScoresGroupedByNameSourceType

* chore: push

* fix: stabilize hook dependency

* Revert "fixup-remove: upgrade to nextjs v15 (#8795)"

This reverts commit 50b7423.

* chore: eslint

---------

Co-authored-by: Nimar <[email protected]>

* update grid layout

* fix toggle

* ugly hack to make resizable work in turbopack

---------

Co-authored-by: Steffen Schmitz <[email protected]>
Co-authored-by: Leo Weigand <[email protected]>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: Marc Klingen <[email protected]>
gongxh13 pushed a commit to gongxh13/langfuse that referenced this pull request Sep 4, 2025
* chore: upgrade to nextjs v15

* update mui x-tree-view

* upgrade next themese

* update react-day-picker react-resizable-panels

* update sonner

* update next-query-params

* update react-email

* upgrade types react in shared

* upgrade next in ee

* next config remove now stable hook

* fix next-themes not exporting prop types directly anymore

* fix mui-x-tree peer dependency

* fix markdown viewer (ugly) to get around stricter typing

* add config to oltp protobus for nextjs15

* HACK: temp circumvent ApiRouteConfig typing

* TEMP: try nextjs15 workaround for SCIM

* try more ram

* not experimental no more

* moar memory

* update memory

* over 8000

* fix turbopack issues

* fix dockerfile

* default to turbo in web

* accept warnings for now

* cleanup

* cleanup

* remove tiktoken stuff

* chore: move obsevation type setting override to mapper (langfuse#8714)

* chore: move obsevation type setting override to mapper

* simplify mapper

* map nicer

* simplify

* feat(single-trace): add copy button on value cell of json view (langfuse#8871)

* fix: use leftUTF8 for input/output truncation on clickhouse (langfuse#8869)

* chose: use leftUTF8 for input/output truncation on clickhouse

* chore: skip truncation linebreak

* fix(trace-detail): guard against zero latency in trace tree (langfuse#8874)

fix(trace-detail): guard against zero latency

* chore: patch flaky trace repository test (langfuse#8870)

* chore: bump dd-trace to 5.65.0 (langfuse#8882)

* fix(prompts): subfolders hiding prompts (langfuse#8876)

* fix(prompts): subfolders hiding prompts

* Update web/src/features/prompts/server/routers/promptRouter.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix da lint!

* fix

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix(trace-single-ui): fix unavailable ref (langfuse#8883)

* fix(trace-single-ui): fix unavailable ref

* really fix it

* chore: release v3.106.4

* chore: add env note to review.md (langfuse#8888)

* feat(table-ui): filter score columns to show score only if has value for given table (langfuse#8865)

* feat(table-ui): filter score columns to show score only if has value for given table

* chore: refactor analytics

* chore: include dataset id in filter condition for DRI scores

* chore: fix tests

* chore: await data

* fixup-remove: upgrade to nextjs v15 (langfuse#8795)

* chore: simplify query

* chore: remove getRunScoresGroupedByNameSourceType

* chore: push

* fix: stabilize hook dependency

* Revert "fixup-remove: upgrade to nextjs v15 (langfuse#8795)"

This reverts commit 50b7423.

* chore: eslint

---------

Co-authored-by: Nimar <[email protected]>

* update grid layout

* fix toggle

* ugly hack to make resizable work in turbopack

---------

Co-authored-by: Steffen Schmitz <[email protected]>
Co-authored-by: Leo Weigand <[email protected]>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: Marc Klingen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant