Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

nimarb
Copy link
Contributor

@nimarb nimarb commented Sep 2, 2025

Important

Fixes prompt visibility and navigation issues with conflicting folder/prompt names by updating tests, components, and server queries.

  • Behavior:
    • Fixes bug LFE-6515 where prompts with names conflicting with folder prefixes were hidden.
    • Updates folder navigation to correctly display individual prompts and subfolders in prompts-trpc.servertest.ts.
    • Ensures search functionality works across conflicting folder/prompt names.
  • Components:
    • Adds fullPath to PromptTableRow in prompts-table.tsx for accurate navigation and API calls.
    • Updates PromptTable to use fullPath for folder navigation and prompt actions.
  • Server:
    • Modifies promptRouter.ts to handle folder and prompt queries with row_type metadata.
    • Updates SQL queries in generatePromptQuery to differentiate between folders and individual prompts.

This description was created by Ellipsis for d35930c. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 2, 2025
@dosubot dosubot bot added the bug Something isn't working label Sep 2, 2025
@nimarb nimarb enabled auto-merge September 3, 2025 08:59
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 3, 2025
@nimarb nimarb added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 5c8e4d6 Sep 3, 2025
29 checks passed
@nimarb nimarb deleted the nimar/lfe-6515-prompt-folder-same-name-as-prompt branch September 3, 2025 09:13
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 3, 2025
gongxh13 pushed a commit to gongxh13/langfuse that referenced this pull request Sep 3, 2025
* fix(prompts): subfolders hiding prompts

* Update web/src/features/prompts/server/routers/promptRouter.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix da lint!

* fix

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
nimarb added a commit that referenced this pull request Sep 3, 2025
* fix(prompts): subfolders hiding prompts

* Update web/src/features/prompts/server/routers/promptRouter.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix da lint!

* fix

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
nimarb added a commit that referenced this pull request Sep 4, 2025
* chore: upgrade to nextjs v15

* update mui x-tree-view

* upgrade next themese

* update react-day-picker react-resizable-panels

* update sonner

* update next-query-params

* update react-email

* upgrade types react in shared

* upgrade next in ee

* next config remove now stable hook

* fix next-themes not exporting prop types directly anymore

* fix mui-x-tree peer dependency

* fix markdown viewer (ugly) to get around stricter typing

* add config to oltp protobus for nextjs15

* HACK: temp circumvent ApiRouteConfig typing

* TEMP: try nextjs15 workaround for SCIM

* try more ram

* not experimental no more

* moar memory

* update memory

* over 8000

* fix turbopack issues

* fix dockerfile

* default to turbo in web

* accept warnings for now

* cleanup

* cleanup

* remove tiktoken stuff

* chore: move obsevation type setting override to mapper (#8714)

* chore: move obsevation type setting override to mapper

* simplify mapper

* map nicer

* simplify

* feat(single-trace): add copy button on value cell of json view (#8871)

* fix: use leftUTF8 for input/output truncation on clickhouse (#8869)

* chose: use leftUTF8 for input/output truncation on clickhouse

* chore: skip truncation linebreak

* fix(trace-detail): guard against zero latency in trace tree (#8874)

fix(trace-detail): guard against zero latency

* chore: patch flaky trace repository test (#8870)

* chore: bump dd-trace to 5.65.0 (#8882)

* fix(prompts): subfolders hiding prompts (#8876)

* fix(prompts): subfolders hiding prompts

* Update web/src/features/prompts/server/routers/promptRouter.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix da lint!

* fix

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix(trace-single-ui): fix unavailable ref (#8883)

* fix(trace-single-ui): fix unavailable ref

* really fix it

* chore: release v3.106.4

* chore: add env note to review.md (#8888)

* feat(table-ui): filter score columns to show score only if has value for given table (#8865)

* feat(table-ui): filter score columns to show score only if has value for given table

* chore: refactor analytics

* chore: include dataset id in filter condition for DRI scores

* chore: fix tests

* chore: await data

* fixup-remove: upgrade to nextjs v15 (#8795)

* chore: simplify query

* chore: remove getRunScoresGroupedByNameSourceType

* chore: push

* fix: stabilize hook dependency

* Revert "fixup-remove: upgrade to nextjs v15 (#8795)"

This reverts commit 50b7423.

* chore: eslint

---------

Co-authored-by: Nimar <[email protected]>

* update grid layout

* fix toggle

* ugly hack to make resizable work in turbopack

---------

Co-authored-by: Steffen Schmitz <[email protected]>
Co-authored-by: Leo Weigand <[email protected]>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: Marc Klingen <[email protected]>
gongxh13 pushed a commit to gongxh13/langfuse that referenced this pull request Sep 4, 2025
* chore: upgrade to nextjs v15

* update mui x-tree-view

* upgrade next themese

* update react-day-picker react-resizable-panels

* update sonner

* update next-query-params

* update react-email

* upgrade types react in shared

* upgrade next in ee

* next config remove now stable hook

* fix next-themes not exporting prop types directly anymore

* fix mui-x-tree peer dependency

* fix markdown viewer (ugly) to get around stricter typing

* add config to oltp protobus for nextjs15

* HACK: temp circumvent ApiRouteConfig typing

* TEMP: try nextjs15 workaround for SCIM

* try more ram

* not experimental no more

* moar memory

* update memory

* over 8000

* fix turbopack issues

* fix dockerfile

* default to turbo in web

* accept warnings for now

* cleanup

* cleanup

* remove tiktoken stuff

* chore: move obsevation type setting override to mapper (langfuse#8714)

* chore: move obsevation type setting override to mapper

* simplify mapper

* map nicer

* simplify

* feat(single-trace): add copy button on value cell of json view (langfuse#8871)

* fix: use leftUTF8 for input/output truncation on clickhouse (langfuse#8869)

* chose: use leftUTF8 for input/output truncation on clickhouse

* chore: skip truncation linebreak

* fix(trace-detail): guard against zero latency in trace tree (langfuse#8874)

fix(trace-detail): guard against zero latency

* chore: patch flaky trace repository test (langfuse#8870)

* chore: bump dd-trace to 5.65.0 (langfuse#8882)

* fix(prompts): subfolders hiding prompts (langfuse#8876)

* fix(prompts): subfolders hiding prompts

* Update web/src/features/prompts/server/routers/promptRouter.ts

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix da lint!

* fix

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

* fix(trace-single-ui): fix unavailable ref (langfuse#8883)

* fix(trace-single-ui): fix unavailable ref

* really fix it

* chore: release v3.106.4

* chore: add env note to review.md (langfuse#8888)

* feat(table-ui): filter score columns to show score only if has value for given table (langfuse#8865)

* feat(table-ui): filter score columns to show score only if has value for given table

* chore: refactor analytics

* chore: include dataset id in filter condition for DRI scores

* chore: fix tests

* chore: await data

* fixup-remove: upgrade to nextjs v15 (langfuse#8795)

* chore: simplify query

* chore: remove getRunScoresGroupedByNameSourceType

* chore: push

* fix: stabilize hook dependency

* Revert "fixup-remove: upgrade to nextjs v15 (langfuse#8795)"

This reverts commit 50b7423.

* chore: eslint

---------

Co-authored-by: Nimar <[email protected]>

* update grid layout

* fix toggle

* ugly hack to make resizable work in turbopack

---------

Co-authored-by: Steffen Schmitz <[email protected]>
Co-authored-by: Leo Weigand <[email protected]>
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Co-authored-by: Marc Klingen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant