Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

marliessophie
Copy link
Member

@marliessophie marliessophie commented Sep 3, 2025

Important

Refactor peek view implementation by removing polling logic, introducing usePeekNavigation for navigation, and updating components to use the new system.

  • Behavior:
    • Removes polling logic and dependency on table state from peek implementation in data-table.tsx and peek.tsx.
    • Introduces usePeekNavigation hook in usePeekNavigation.ts for managing peek view navigation.
    • Refactors DataTablePeekViewProps to include new navigation and event handling methods.
  • Hooks:
    • Adds usePeekNavigation in usePeekNavigation.ts for managing peek view navigation.
    • Adds usePeekCompareDetail in usePeekCompareDetail.ts for handling trace comparison details.
    • Adds usePeekRunsCompareData in usePeekRunsCompareData.ts for fetching run comparison data.
    • Removes deprecated hooks: usePeekView, useDatasetComparePeekState, useObservationPeekState, useTracePeekState, and others.
  • Components:
    • Updates DataTable in data-table.tsx to use new peek view props and navigation.
    • Updates TablePeekView in peek.tsx to handle new navigation and event logic.
    • Refactors components like PeekDatasetCompareDetail, PeekViewEvaluatorConfigDetail, PeekViewEvaluatorTemplateDetail, PeekViewObservationDetail, and PeekViewTraceDetail to use new navigation system.
  • Misc:
    • Updates dataset-router.ts to support new query parameters for dataset run items.
    • Adds urlSearchParamsToQuery utility in navigation.ts for converting URLSearchParams to query objects.

This description was created by Ellipsis for 25e2d47. You can customize this summary. It will automatically update as commits are pushed.


edit by Leo: fixes LFE-6243 as well

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 3, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 3, 2025
@dosubot dosubot bot added the auto-merge This PR is set to be merged label Sep 9, 2025
@marliessophie marliessophie added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit a7e3dec Sep 9, 2025
30 checks passed
@marliessophie marliessophie deleted the marlies/lfe-6485 branch September 9, 2025 15:57
@dosubot dosubot bot removed the auto-merge This PR is set to be merged label Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants