-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chore(peek): remove polling logic and dependency on table state from peek implementation #8885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed URL management in table components
leoweigand
reviewed
Sep 4, 2025
web/src/components/table/peek/hooks/usePeekExpandObservationDetail.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Refactor peek view implementation by removing polling logic, introducing
usePeekNavigation
for navigation, and updating components to use the new system.data-table.tsx
andpeek.tsx
.usePeekNavigation
hook inusePeekNavigation.ts
for managing peek view navigation.DataTablePeekViewProps
to include new navigation and event handling methods.usePeekNavigation
inusePeekNavigation.ts
for managing peek view navigation.usePeekCompareDetail
inusePeekCompareDetail.ts
for handling trace comparison details.usePeekRunsCompareData
inusePeekRunsCompareData.ts
for fetching run comparison data.usePeekView
,useDatasetComparePeekState
,useObservationPeekState
,useTracePeekState
, and others.DataTable
indata-table.tsx
to use new peek view props and navigation.TablePeekView
inpeek.tsx
to handle new navigation and event logic.PeekDatasetCompareDetail
,PeekViewEvaluatorConfigDetail
,PeekViewEvaluatorTemplateDetail
,PeekViewObservationDetail
, andPeekViewTraceDetail
to use new navigation system.dataset-router.ts
to support new query parameters for dataset run items.urlSearchParamsToQuery
utility innavigation.ts
for converting URLSearchParams to query objects.This description was created by
for 25e2d47. You can customize this summary. It will automatically update as commits are pushed.
edit by Leo: fixes LFE-6243 as well