Allow compile with gcc -Werror=format-security #4024
Conversation
Fixes "format not a string literal and no format arguments" compile error with -Werror=format-security
| @@ -552,7 +552,7 @@ int git_index_clear(git_index *index) | |||
|
|
|||
| static int create_index_error(int error, const char *msg) | |||
| { | |||
| giterr_set_str(GITERR_INDEX, msg); | |||
| giterr_set_str(GITERR_INDEX, "index creation error '%s'", msg); | |||
There was a problem hiding this comment.
You're changing the behavior rather drastically. The name create_index_error indicates that this function creates an index error; it doesn't indicate that there was an error creating the index.
This will produce errors like:
index creation error 'Failed to read index: The index is in-memory only'
Which does not make sense.
There are a variety of options for fixing this, simply giterr_set_str(GITERR_INDEX, "%s", msg); is certainly the simplest.
There was a problem hiding this comment.
No, I misread this. This doesn't even compile; giterr_set_str takes a string argument, not a format.
|
Can you share the warnings your compiler is generating? The format errors should have been fixed in #4009 which IIRC came after the RC. |
|
It feels to me like you were seeing these warnings reported in your build, but those issues were coincidentally fixed to use I'm closing this; please do resubmit a change if you think that this is not yet fixed in master. Thanks! |
When building a v.25-rc1 RPM on Fedora 25, the default compiler flags include -Werror=format-security and a compile of v.25-rc1 fails in two locations with "format not a string literal and no format arguments".
Please merge this PR.