Add Stashes.Remove #375
Merged
Add Stashes.Remove #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static void git_stash_drop(RepositorySafeHandle repo, int index) | ||
| { | ||
| int res = NativeMethods.git_stash_drop(repo, (UIntPtr)index); | ||
| Ensure.BooleanResult(res); |
There was a problem hiding this comment.
You should encapsulate these two lines in a using (ThreadAffinity()) block
|
Sorry for my styling mistakes @nulltoken, I am not yet at ease with all the code styles to follow... |
| int index; | ||
| if(!TryExtractStashIndexFromRefLog(stashRefLog, out index) || index < 0) | ||
| { | ||
| throw new ArgumentException("must be a valid stash log reference. Pattern is 'stash@{i}' where 'i' is an integer", "stashRefLog"); |
There was a problem hiding this comment.
Potential nitpick: "... where is a positive integer" ?
|
Merged! 🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my last pull request, here is the code to drop an existing stash.
usage example :
repo.Stashes.Remove("stash@{0}");Any comment will be appreciated!