Emit warning on metadata changes for shared images #4783
Merged
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice!
|
jcupitt
approved these changes
Dec 6, 2025
Member
|
I'll remove the ref count test from that PR I made, this one is better. |
Member
|
printf("vips_image_set: set \"%s\" on shared image\n", name); |
Member
Author
|
This PR identifies three code paths that may remove or set a metadata item on a shared image: libvips/libvips/foreign/dzsave.c Line 1638 in 2e49443 libvips/libvips/foreign/heifsave.c Line 318 in 2e49443 libvips/libvips/foreign/vips2tiff.c Line 1986 in 2e49443 |
Reintroduce the code removed in commit e4db747. The warning is now only emitted in debug builds and when the `VIPS_LEAK` mechanism is enabled.
69b1496 to
07bbbd8
Compare
jcupitt
approved these changes
Dec 6, 2025
Member
|
Ah what a pain. Let's merge and fix those in a follow-up. |
This was referenced Dec 7, 2025
jcupitt
added a commit
that referenced
this pull request
Dec 8, 2025
Very like the dzsave change -- we need to make a private image to signal the minimise behaviour we want to the thraedpool. See #4783
jcupitt
added a commit
that referenced
this pull request
Dec 8, 2025
Very like the dzsave change -- we need to make a private image to signal the minimise behaviour we want to the thraedpool. See #4783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce the code removed in commit e4db747. The warning is now only emitted in debug builds and when the
VIPS_LEAKmechanism is enabled.