fix metadata change warning for heifsave #4790
Merged
+6
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were removing the orientation tag from the image during save, and this triggered a warning about a shared image pointer. This PR removes the metadata change -- we were removing the libvips metadata orientation fields, but not regenerating the exif data block, which is what we we were actually writing, so the removal had no effect. We could call `vips__exif_update()` to rebuild the exif block, but that's not part of the libvips API, so isn't available when heifsave is a module.
Member
Author
|
Also improve a confusing indent. |
kleisauke
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were removing the orientation tag from the image during save, and this triggered a warning about a shared image pointer.
This PR removes the metadata change -- we were removing the libvips metadata orientation fields, but not regenerating the exif data block, which is what we we were actually writing, so the removal had no effect.
We could call
vips__exif_update()to rebuild the exif block, but that's not part of the libvips API, so isn't available when heifsave is a module.See #4783 for reporting PR.