Thanks to visit codestin.com
Credit goes to github.com

[libc] implement template functions for localtime #110363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

zimirza wants to merge 166 commits into llvm:main from zimirza:localtime_107597

Contributor

zimirza commented Sep 28, 2024 •

edited

Loading

This is an implementation for template functions of localtime.

Update for this pull request: Implementation as been removed from this pull request and will be added to a new one. This is because this pull request is getting big. This pull request will only contain template functions in order to implement localtime.

Update: The implementation is available in https://github.com/zimirza/llvm-project/tree/localtime_implementation.

github-actions bot commented Sep 28, 2024 •

edited

Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

zimirza force-pushed the localtime_107597 branch 2 times, most recently from 6e15b2f to 15a5bef Compare

September 28, 2024 14:09

zimirza mentioned this pull request

[clang-tidy] add ctime and localtime to clang-tidy #110366

Open

graphite-app bot reviewed

View reviewed changes

libc/test/src/time/localtime_s_test.cpp Outdated Show resolved Hide resolved

graphite-app bot reviewed

View reviewed changes

libc/src/time/time_utils.cpp Outdated Show resolved Hide resolved

graphite-app bot reviewed

View reviewed changes

libc/src/time/time_utils.cpp Outdated Show resolved Hide resolved

zimirza force-pushed the localtime_107597 branch from 95ad2ec to 4e12c67 Compare

October 6, 2024 20:38

graphite-app bot reviewed

View reviewed changes

libc/src/time/time_utils.cpp Outdated Show resolved Hide resolved

zimirza force-pushed the localtime_107597 branch from 469939e to 47a3589 Compare

October 8, 2024 13:07

graphite-app bot reviewed

View reviewed changes

libc/src/time/timezone.cpp Outdated Show resolved Hide resolved

Contributor Author

zimirza commented Oct 8, 2024

Instead of using /etc/timezone, it is better to parse /etc/localtime.

petrhosek reviewed

View reviewed changes

libc/src/time/time_utils.cpp Outdated Show resolved Hide resolved

petrhosek reviewed

View reviewed changes

libc/src/time/time_utils.cpp Outdated Show resolved Hide resolved

zimirza force-pushed the localtime_107597 branch from 5c51ae3 to 316e0a9 Compare

December 23, 2024 03:59

Contributor Author

zimirza commented Dec 26, 2024

Even though this pull request is not yet finished, I thought it would be great to get a review since this pull request is getting quite big. There are some unit tests that are not working, and have been commented out.

zimirza marked this pull request as ready for review

December 26, 2024 02:00

zimirza force-pushed the localtime_107597 branch 2 times, most recently from eca1d44 to 1456c67 Compare

December 26, 2024 06:08

petrhosek reviewed

View reviewed changes

libc/src/time/timezone.cpp Outdated Show resolved Hide resolved

petrhosek reviewed

View reviewed changes

libc/src/time/timezone.cpp Outdated Show resolved Hide resolved

zimirza force-pushed the localtime_107597 branch 2 times, most recently from 2f14147 to 6a84f62 Compare

January 3, 2025 20:34

nickdesaulniers self-requested a review

January 7, 2025 18:52

Member

nickdesaulniers commented Jan 7, 2025

(currently not finished)

Consider marking this as a "draft" in the github UI.

Member

petrhosek commented Jan 7, 2025

This is a large change and there are some aspects that will likely require more discussion, like what kind of TZ support we even want and how to do it, whether we could share the implementation with libc++, etc. This could be discussed either on Discourse or at the public LLVM-libc meeting (or both). In the meantime, I think the best path forward would be to split this change into multiple changes, with the first one being just an empty minimal implementation which could be merged while we're discussing the implementation details.

Contributor Author

zimirza commented Jan 8, 2025

(currently not finished)

Consider marking this as a "draft" in the github UI.

Sure, I will mark this as a draft.

zimirza marked this pull request as draft

January 8, 2025 08:09

zimirza force-pushed the localtime_107597 branch from 7d246be to 88911f0 Compare

January 16, 2025 13:46

zimirza changed the title ~~[libc] implement localtime~~ [libc] implement template functions for localtime

zimirza added 13 commits

April 30, 2025 14:39


          include file

4db01f0


          format code with clang-format

3809ccb


          revert ctime_r_test and remove dst function for another pull request

8f69ff3


          remove constant for a different pull request

9ef0978


          revert ctime and remove timezone implementation

c368e00


          add fopen to ctime_r

57dbc2f


          revert: ctime


          revert ctime unit tests

95bc940


          revert: ctime unit tests

40f1963


          revert: ctime

99b841a


          revert: update_from_seconds

5a01a09


          revert: update_from_seconds

47c596f


          rerun github actions

150231f

Contributor Author

zimirza commented Apr 30, 2025

I have limited this pull request to template functions for localtime and localtime_r. I was thinking that after this pull request is merged, I can create a new pull request with the actual implementation for timezones and daylight saving time. Please do let me know what you think.

lntue reviewed

View reviewed changes

libc/hdr/localtime_macros.h Outdated Show resolved Hide resolved

lntue reviewed

View reviewed changes

libc/src/time/time_utils.h Outdated Show resolved Hide resolved

lntue reviewed

View reviewed changes

libc/src/time/time_utils.h Outdated Show resolved Hide resolved

lntue reviewed

View reviewed changes

libc/src/time/linux/localtime_utils.h Outdated Show resolved Hide resolved

zimirza added 6 commits

May 2, 2025 13:55


          remove localtime_macros.h

b4e0a1e


          function get_localtime should not be extern

a1d1985


          remove get_env_var function from this pull request

5063e61


          use c++-style references

79174b2


          format code with clang-format

d490c40


          use c++ style references

f7d899e

petrhosek reviewed

View reviewed changes

libc/src/time/linux/localtime_utils.cpp Outdated Show resolved Hide resolved

petrhosek reviewed

View reviewed changes

libc/src/time/linux/timezone.h Outdated Show resolved Hide resolved

petrhosek reviewed

View reviewed changes

libc/src/time/linux/timezone.h Outdated Show resolved Hide resolved

zimirza added 3 commits

May 6, 2025 16:50


          removed timezone implementation definitions

68d7723


          removed app.h from time_utils.cpp

467adb1


          fix: code format

c4a2613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

petrhosek petrhosek left review comments

lntue lntue left review comments

graphite-app[bot] graphite-app[bot] left review comments

michaelrj-google michaelrj-google requested changes

nickdesaulniers Awaiting requested review from nickdesaulniers

Labels

None yet