[clang-tidy] add `ctime` and `localtime` to `clang-tidy` #110366

zimirza · 2024-09-28T15:07:43Z

Closes #107445

llvmbot · 2024-09-28T15:08:23Z

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-static-analyzer-1

Author: Зишан Мирза (zimirza)

Changes

Closes #107445

Full diff: https://github.com/llvm/llvm-project/pull/110366.diff

5 Files Affected:

(modified) clang/docs/tools/clang-formatted-files.txt (+8)
(modified) clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp (+4)
(modified) clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc (+4)
(modified) clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc (+6)
(modified) clang/test/Analysis/cert/env34-c.c (+8-1)

diff --git a/clang/docs/tools/clang-formatted-files.txt b/clang/docs/tools/clang-formatted-files.txt
index 67ff085144f4de..5223ca82a5b575 100644
--- a/clang/docs/tools/clang-formatted-files.txt
+++ b/clang/docs/tools/clang-formatted-files.txt
@@ -3058,6 +3058,14 @@ libc/src/threads/linux/thrd_join.cpp
 libc/src/threads/linux/Thread.h
 libc/src/time/asctime.cpp
 libc/src/time/asctime.h
+libc/src/time/ctime.cpp
+libc/src/time/ctime.h
+libc/src/time/ctime_r.cpp
+libc/src/time/ctime_r.h
+libc/src/time/localtime.cpp
+libc/src/time/localtime.h
+libc/src/time/localtime_r.cpp
+libc/src/time/localtime_r.h
 libc/src/time/asctime_r.cpp
 libc/src/time/asctime_r.h
 libc/src/time/gmtime.cpp
diff --git a/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
index fefe846b6911f7..9c34d3636c8488 100644
--- a/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
@@ -76,6 +76,10 @@ class InvalidPtrChecker
        &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
       {{CDM::CLibrary, {"asctime"}, 1},
        &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
+      {{CDM::CLibrary, {"ctime"}, 1},
+       &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
+      {{CDM::CLibrary, {"localtime"}, 1},
+       &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
   };
 
   // The private members of this checker corresponding to commandline options
diff --git a/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc b/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc
index 463ce921f0672f..aca22f869b5291 100644
--- a/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc
+++ b/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc
@@ -220,6 +220,10 @@ SYMBOL(and, None, <iso646.h>)
 SYMBOL(and_eq, None, <iso646.h>)
 SYMBOL(asctime, None, <time.h>)
 SYMBOL(asctime_s, None, <time.h>)
+SYMBOL(ctime, None, <time.h>)
+SYMBOL(ctime_s, None, <time.h>)
+SYMBOL(localtime, None, <time.h>)
+SYMBOL(localtime_s, None, <time.h>)
 SYMBOL(asin, None, <math.h>)
 SYMBOL(asinf, None, <math.h>)
 SYMBOL(asinh, None, <math.h>)
diff --git a/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc b/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc
index b46bd2e4d7a4b5..8e3471e2fc5729 100644
--- a/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc
+++ b/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc
@@ -617,6 +617,12 @@ SYMBOL(as_writable_bytes, std::, <span>)
 SYMBOL(asctime, std::, <ctime>)
 SYMBOL(asctime, None, <ctime>)
 SYMBOL(asctime, None, <time.h>)
+SYMBOL(ctime, std::, <time.h>)
+SYMBOL(ctime, None, <ctime>)
+SYMBOL(ctime, None, <time.h>)
+SYMBOL(localtime, std::, <ctime>)
+SYMBOL(localtime, None, <ctime>)
+SYMBOL(localtime, None, <time.h>)
 SYMBOL(asin, std::, <cmath>)
 SYMBOL(asin, None, <cmath>)
 SYMBOL(asin, None, <math.h>)
diff --git a/clang/test/Analysis/cert/env34-c.c b/clang/test/Analysis/cert/env34-c.c
index d307f0d8f4bb01..66ba0be4a67bba 100644
--- a/clang/test/Analysis/cert/env34-c.c
+++ b/clang/test/Analysis/cert/env34-c.c
@@ -15,7 +15,14 @@ lconv *localeconv(void);
 
 typedef struct {
 } tm;
-char *asctime(const tm *timeptr);
+char *asctime(const tm *timeptr)
+;
+typedef struct {
+} tm;
+char *ctime(const tm *timeptr);
+typedef struct {
+} tm;
+struct tm *localtime(struct tm *tm);
 
 int strcmp(const char*, const char*);
 extern void foo(char *e);

llvmbot · 2024-09-28T15:08:23Z

@llvm/pr-subscribers-clang

Author: Зишан Мирза (zimirza)

Changes

Closes #107445

Full diff: https://github.com/llvm/llvm-project/pull/110366.diff

5 Files Affected:

(modified) clang/docs/tools/clang-formatted-files.txt (+8)
(modified) clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp (+4)
(modified) clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc (+4)
(modified) clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc (+6)
(modified) clang/test/Analysis/cert/env34-c.c (+8-1)

diff --git a/clang/docs/tools/clang-formatted-files.txt b/clang/docs/tools/clang-formatted-files.txt
index 67ff085144f4de..5223ca82a5b575 100644
--- a/clang/docs/tools/clang-formatted-files.txt
+++ b/clang/docs/tools/clang-formatted-files.txt
@@ -3058,6 +3058,14 @@ libc/src/threads/linux/thrd_join.cpp
 libc/src/threads/linux/Thread.h
 libc/src/time/asctime.cpp
 libc/src/time/asctime.h
+libc/src/time/ctime.cpp
+libc/src/time/ctime.h
+libc/src/time/ctime_r.cpp
+libc/src/time/ctime_r.h
+libc/src/time/localtime.cpp
+libc/src/time/localtime.h
+libc/src/time/localtime_r.cpp
+libc/src/time/localtime_r.h
 libc/src/time/asctime_r.cpp
 libc/src/time/asctime_r.h
 libc/src/time/gmtime.cpp
diff --git a/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
index fefe846b6911f7..9c34d3636c8488 100644
--- a/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/cert/InvalidPtrChecker.cpp
@@ -76,6 +76,10 @@ class InvalidPtrChecker
        &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
       {{CDM::CLibrary, {"asctime"}, 1},
        &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
+      {{CDM::CLibrary, {"ctime"}, 1},
+       &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
+      {{CDM::CLibrary, {"localtime"}, 1},
+       &InvalidPtrChecker::postPreviousReturnInvalidatingCall},
   };
 
   // The private members of this checker corresponding to commandline options
diff --git a/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc b/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc
index 463ce921f0672f..aca22f869b5291 100644
--- a/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc
+++ b/clang/lib/Tooling/Inclusions/Stdlib/CSymbolMap.inc
@@ -220,6 +220,10 @@ SYMBOL(and, None, <iso646.h>)
 SYMBOL(and_eq, None, <iso646.h>)
 SYMBOL(asctime, None, <time.h>)
 SYMBOL(asctime_s, None, <time.h>)
+SYMBOL(ctime, None, <time.h>)
+SYMBOL(ctime_s, None, <time.h>)
+SYMBOL(localtime, None, <time.h>)
+SYMBOL(localtime_s, None, <time.h>)
 SYMBOL(asin, None, <math.h>)
 SYMBOL(asinf, None, <math.h>)
 SYMBOL(asinh, None, <math.h>)
diff --git a/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc b/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc
index b46bd2e4d7a4b5..8e3471e2fc5729 100644
--- a/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc
+++ b/clang/lib/Tooling/Inclusions/Stdlib/StdSymbolMap.inc
@@ -617,6 +617,12 @@ SYMBOL(as_writable_bytes, std::, <span>)
 SYMBOL(asctime, std::, <ctime>)
 SYMBOL(asctime, None, <ctime>)
 SYMBOL(asctime, None, <time.h>)
+SYMBOL(ctime, std::, <time.h>)
+SYMBOL(ctime, None, <ctime>)
+SYMBOL(ctime, None, <time.h>)
+SYMBOL(localtime, std::, <ctime>)
+SYMBOL(localtime, None, <ctime>)
+SYMBOL(localtime, None, <time.h>)
 SYMBOL(asin, std::, <cmath>)
 SYMBOL(asin, None, <cmath>)
 SYMBOL(asin, None, <math.h>)
diff --git a/clang/test/Analysis/cert/env34-c.c b/clang/test/Analysis/cert/env34-c.c
index d307f0d8f4bb01..66ba0be4a67bba 100644
--- a/clang/test/Analysis/cert/env34-c.c
+++ b/clang/test/Analysis/cert/env34-c.c
@@ -15,7 +15,14 @@ lconv *localeconv(void);
 
 typedef struct {
 } tm;
-char *asctime(const tm *timeptr);
+char *asctime(const tm *timeptr)
+;
+typedef struct {
+} tm;
+char *ctime(const tm *timeptr);
+typedef struct {
+} tm;
+struct tm *localtime(struct tm *tm);
 
 int strcmp(const char*, const char*);
 extern void foo(char *e);

EugeneZelenko · 2024-09-29T13:44:53Z

Please mention changes in Release Notes.

zimirza · 2024-09-30T14:34:55Z

Sure, I can add the changes to the release notes. I noticed that tests did not work as expected. I can make this pull request a draft, since I need to figure out why tests did not work.

zimirza · 2024-09-30T14:43:55Z

This pull request should not be merged before #110363.

clang-tools-extra/docs/ReleaseNotes.rst

github-actions · 2024-09-30T16:50:09Z

✅ With the latest revision this PR passed the C/C++ code formatter.

EugeneZelenko

Please also rebase from main.

clang-tools-extra/docs/ReleaseNotes.rst

Closes llvm#107445

add `ctime` and `localtime` to unsafe functions check function

add changes to release notes

fix: tests

zimirza · 2025-04-30T15:05:25Z

localtime_s was removed from #110363, and will be added to a new pull request and ctime_s has not been merged yet (#110676). It might be a good wait before merging this pull request.

clang-tools-extra/docs/ReleaseNotes.rst

added to a new pull request.

zimirza · 2025-05-02T13:04:13Z

localtime_s was removed from #110363, and will be added to a new pull request and ctime_s has not been merged yet (#110676). It might be a good wait before merging this pull request.

I think it is better to remove localtime_s and ctime_s from this pull request in order to keep changes small. These will be added to a new pull request when the implementations are merged.

zimirza · 2025-05-02T13:30:21Z

localtime_s was removed from #110363, and will be added to a new pull request and ctime_s has not been merged yet (#110676). It might be a good wait before merging this pull request.

I think it is better to remove localtime_s and ctime_s from this pull request in order to keep changes small. These will be added to a new pull request when the implementations are merged.

localtime_s and ctime_s is currently available in a separate branch: https://github.com/zimirza/llvm-project/tree/add_time_to_clang_tidy_with_ctime_s_and_localtime_s

llvmbot added clang Clang issues not falling into any other category clang:static analyzer labels Sep 28, 2024

llvmbot added clang-tools-extra clang-tidy labels Sep 28, 2024

EugeneZelenko requested review from 5chmidti, PiotrZSL, SimplyDanny and HerrCai0907 September 29, 2024 13:43

zimirza force-pushed the add_time_to_clang_tidy branch from 9983c6e to 5deca5d Compare September 30, 2024 14:37

zimirza marked this pull request as draft September 30, 2024 14:37

EugeneZelenko reviewed Sep 30, 2024

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

EugeneZelenko reviewed Sep 30, 2024

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

EugeneZelenko reviewed Sep 30, 2024

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

EugeneZelenko reviewed Sep 30, 2024

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

zimirza force-pushed the add_time_to_clang_tidy branch from db3832f to 298fa84 Compare December 26, 2024 03:35

zimirza force-pushed the add_time_to_clang_tidy branch from 32517de to 892cef4 Compare January 4, 2025 11:14

EugeneZelenko requested changes Jan 4, 2025

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

EugeneZelenko reviewed Apr 30, 2025

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

Зишан Мирза added 6 commits April 30, 2025 16:41

[clang-tidy] add ctime and localtime to clang-tidy

79d6622

Closes llvm#107445

[clang-tidy] add times to clang-tidy

f90a091

add `ctime` and `localtime` to unsafe functions check function

[clang-tidy] add ctime and localtime to clang-tidy

d5d985a

add changes to release notes

[clang-tidy] add ctime and localtime to clang-tidy

3290834

fix: tests

undo symbols, since these should be automatically generated

cc3fa57

moved release notes for ctime and localtime

d372eaf

Зишан Мирза and others added 13 commits April 30, 2025 16:44

format code with clang-format

fdf4245

fix: document name

45074ca

fix: path for unsafe-functions

95342b9

fix path

92cda2b

fix: release notes for clang-tidy

460ccf9

fix: path for unsafe functions in release notes

b70a529

fix path for unsafe functions in release notes

b4d5208

fix: static analyzer for ctime_s

18e882e

fix argument number

f1540c5

format code with clang-format

f28b90a

include header file for size_t

9d5fa73

fix clang static analyzer and functions checker

2513ed9

combine bugprone-unsafe-functions release notes

36f2968

zimirza force-pushed the add_time_to_clang_tidy branch from e6ac279 to 36f2968 Compare April 30, 2025 14:46

zimirza added 6 commits April 30, 2025 16:48

fix: rebase from main branch

7685ec0

fix: rebase from main branch

38a2135

fix: rebase from main branch

23d21cd

update release notes for clang-tidy

428c299

update release notes for clang-tidy

4e66050

combine bugprone-unsafe-functions release notes

3326ab2

zimirza marked this pull request as ready for review April 30, 2025 14:58

fix: release notes for unsafe functions

2aabbd7

revert: identifier for bugprone-unsafe-functions

cf1d22d

EugeneZelenko reviewed Apr 30, 2025

View reviewed changes

clang-tools-extra/docs/ReleaseNotes.rst Outdated Show resolved Hide resolved

zimirza added 3 commits May 2, 2025 13:51

remove duplicate entry in release notes

8cd9bd7

removed ctime_s and localtime_s for this pull request. these will be

6d61cac

added to a new pull request.

format code with clang-format

e27e233

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[clang-tidy] add `ctime` and `localtime` to `clang-tidy` #110366

[clang-tidy] add `ctime` and `localtime` to `clang-tidy` #110366

zimirza commented Sep 28, 2024

llvmbot commented Sep 28, 2024 •

edited

Loading

llvmbot commented Sep 28, 2024

EugeneZelenko commented Sep 29, 2024

zimirza commented Sep 30, 2024

zimirza commented Sep 30, 2024

github-actions bot commented Sep 30, 2024 •

edited

Loading

EugeneZelenko left a comment

zimirza commented Apr 30, 2025

zimirza commented May 2, 2025

zimirza commented May 2, 2025

[clang-tidy] add ctime and localtime to clang-tidy #110366

Are you sure you want to change the base?

[clang-tidy] add ctime and localtime to clang-tidy #110366

Conversation

zimirza commented Sep 28, 2024

llvmbot commented Sep 28, 2024 • edited Loading

llvmbot commented Sep 28, 2024

EugeneZelenko commented Sep 29, 2024

zimirza commented Sep 30, 2024

zimirza commented Sep 30, 2024

github-actions bot commented Sep 30, 2024 • edited Loading

EugeneZelenko left a comment

Choose a reason for hiding this comment

zimirza commented Apr 30, 2025

zimirza commented May 2, 2025

zimirza commented May 2, 2025

[clang-tidy] add `ctime` and `localtime` to `clang-tidy` #110366

[clang-tidy] add `ctime` and `localtime` to `clang-tidy` #110366

llvmbot commented Sep 28, 2024 •

edited

Loading

github-actions bot commented Sep 30, 2024 •

edited

Loading