[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

joaosaffran · 2025-07-08T17:12:30Z

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check.

Closes: #126647

…idation/check-descriptors-are-bound

…/textures-not-bind-root-signatures

llvmbot · 2025-07-08T17:13:03Z

@llvm/pr-subscribers-hlsl

Author: None (joaosaffran)

Changes

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check in clang.

Closes: #126647

Full diff: https://github.com/llvm/llvm-project/pull/147573.diff

2 Files Affected:

(added) clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl (+13)
(modified) llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp (+25)

diff --git a/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
new file mode 100644
index 0000000000000..9daf38e30dd67
--- /dev/null
+++ b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
@@ -0,0 +1,13 @@
+// RUN: not %clang_dxc -T cs_6_6 -E CSMain %s 2>&1 | FileCheck %s
+
+// CHECK: error: register srv (space=0, register=0) is bound to a texture or typed buffer.
+
+RWStructuredBuffer<int> Out : register(u0);
+Buffer<float> B : register(t0);
+// Compute Shader for UAV testing
+[numthreads(8, 8, 1)]
+[RootSignature("SRV(t0), UAV(u0)")]
+void CSMain(uint id : SV_GroupID)
+{
+    Out[0] = B[0];
+}
diff --git a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
index a52a04323514c..c34f31fbe35e5 100644
--- a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
+++ b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
@@ -85,6 +85,17 @@ static void reportOverlappingBinding(Module &M, DXILResourceMap &DRM) {
   }
 }
 
+static void
+reportInvalidHandleTyBoundInRs(Module &M, Twine Type,
+                               ResourceInfo::ResourceBinding Binding) {
+  SmallString<128> Message;
+  raw_svector_ostream OS(Message);
+  OS << "register " << Type << " (space=" << Binding.Space
+     << ", register=" << Binding.LowerBound << ")"
+     << " is bound to a texture or typed buffer.";
+  M.getContext().diagnose(DiagnosticInfoGeneric(Message));
+}
+
 static void reportRegNotBound(Module &M, Twine Type,
                               ResourceInfo::ResourceBinding Binding) {
   SmallString<128> Message;
@@ -163,12 +174,26 @@ static void reportErrors(Module &M, DXILResourceMap &DRM,
       ResourceInfo::ResourceBinding Binding = SRV.getBinding();
       if (!Validation.checkTRegBinding(Binding))
         reportRegNotBound(M, "srv", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(SRV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &UAV : DRM.uavs()) {
       ResourceInfo::ResourceBinding Binding = UAV.getBinding();
       if (!Validation.checkURegBinding(Binding))
         reportRegNotBound(M, "uav", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(UAV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &Sampler : DRM.samplers()) {

llvmbot · 2025-07-08T17:13:04Z

@llvm/pr-subscribers-backend-directx

Author: None (joaosaffran)

Changes

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check in clang.

Closes: #126647

Full diff: https://github.com/llvm/llvm-project/pull/147573.diff

2 Files Affected:

(added) clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl (+13)
(modified) llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp (+25)

diff --git a/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
new file mode 100644
index 0000000000000..9daf38e30dd67
--- /dev/null
+++ b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
@@ -0,0 +1,13 @@
+// RUN: not %clang_dxc -T cs_6_6 -E CSMain %s 2>&1 | FileCheck %s
+
+// CHECK: error: register srv (space=0, register=0) is bound to a texture or typed buffer.
+
+RWStructuredBuffer<int> Out : register(u0);
+Buffer<float> B : register(t0);
+// Compute Shader for UAV testing
+[numthreads(8, 8, 1)]
+[RootSignature("SRV(t0), UAV(u0)")]
+void CSMain(uint id : SV_GroupID)
+{
+    Out[0] = B[0];
+}
diff --git a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
index a52a04323514c..c34f31fbe35e5 100644
--- a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
+++ b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
@@ -85,6 +85,17 @@ static void reportOverlappingBinding(Module &M, DXILResourceMap &DRM) {
   }
 }
 
+static void
+reportInvalidHandleTyBoundInRs(Module &M, Twine Type,
+                               ResourceInfo::ResourceBinding Binding) {
+  SmallString<128> Message;
+  raw_svector_ostream OS(Message);
+  OS << "register " << Type << " (space=" << Binding.Space
+     << ", register=" << Binding.LowerBound << ")"
+     << " is bound to a texture or typed buffer.";
+  M.getContext().diagnose(DiagnosticInfoGeneric(Message));
+}
+
 static void reportRegNotBound(Module &M, Twine Type,
                               ResourceInfo::ResourceBinding Binding) {
   SmallString<128> Message;
@@ -163,12 +174,26 @@ static void reportErrors(Module &M, DXILResourceMap &DRM,
       ResourceInfo::ResourceBinding Binding = SRV.getBinding();
       if (!Validation.checkTRegBinding(Binding))
         reportRegNotBound(M, "srv", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(SRV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &UAV : DRM.uavs()) {
       ResourceInfo::ResourceBinding Binding = UAV.getBinding();
       if (!Validation.checkURegBinding(Binding))
         reportRegNotBound(M, "uav", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(UAV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &Sampler : DRM.samplers()) {

llvmbot · 2025-07-08T17:13:04Z

@llvm/pr-subscribers-clang

Author: None (joaosaffran)

Changes

DXC doesn't allow Textures/TypedBuffers to bind with root signature descriptors, this implements the same check in clang.

Closes: #126647

Full diff: https://github.com/llvm/llvm-project/pull/147573.diff

2 Files Affected:

(added) clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl (+13)
(modified) llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp (+25)

diff --git a/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
new file mode 100644
index 0000000000000..9daf38e30dd67
--- /dev/null
+++ b/clang/test/SemaHLSL/RootSignature-Validation-Textures.hlsl
@@ -0,0 +1,13 @@
+// RUN: not %clang_dxc -T cs_6_6 -E CSMain %s 2>&1 | FileCheck %s
+
+// CHECK: error: register srv (space=0, register=0) is bound to a texture or typed buffer.
+
+RWStructuredBuffer<int> Out : register(u0);
+Buffer<float> B : register(t0);
+// Compute Shader for UAV testing
+[numthreads(8, 8, 1)]
+[RootSignature("SRV(t0), UAV(u0)")]
+void CSMain(uint id : SV_GroupID)
+{
+    Out[0] = B[0];
+}
diff --git a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
index a52a04323514c..c34f31fbe35e5 100644
--- a/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
+++ b/llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp
@@ -85,6 +85,17 @@ static void reportOverlappingBinding(Module &M, DXILResourceMap &DRM) {
   }
 }
 
+static void
+reportInvalidHandleTyBoundInRs(Module &M, Twine Type,
+                               ResourceInfo::ResourceBinding Binding) {
+  SmallString<128> Message;
+  raw_svector_ostream OS(Message);
+  OS << "register " << Type << " (space=" << Binding.Space
+     << ", register=" << Binding.LowerBound << ")"
+     << " is bound to a texture or typed buffer.";
+  M.getContext().diagnose(DiagnosticInfoGeneric(Message));
+}
+
 static void reportRegNotBound(Module &M, Twine Type,
                               ResourceInfo::ResourceBinding Binding) {
   SmallString<128> Message;
@@ -163,12 +174,26 @@ static void reportErrors(Module &M, DXILResourceMap &DRM,
       ResourceInfo::ResourceBinding Binding = SRV.getBinding();
       if (!Validation.checkTRegBinding(Binding))
         reportRegNotBound(M, "srv", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(SRV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &UAV : DRM.uavs()) {
       ResourceInfo::ResourceBinding Binding = UAV.getBinding();
       if (!Validation.checkURegBinding(Binding))
         reportRegNotBound(M, "uav", Binding);
+      else {
+        const auto *Handle =
+            dyn_cast_or_null<RawBufferExtType>(UAV.getHandleTy());
+
+        if (!Handle)
+          reportInvalidHandleTyBoundInRs(M, "srv", Binding);
+      }
     }
 
     for (const ResourceInfo &Sampler : DRM.samplers()) {

…/textures-not-bind-root-signatures

joaosaffran · 2025-08-30T01:21:01Z

llvm/include/llvm/Frontend/HLSL/HLSLBinding.h

+  std::optional<const Binding *> findBoundReg(dxil::ResourceClass RC,
+                                              uint32_t Space,
+                                              uint32_t LowerBound,
+                                              uint32_t UpperBound) const {


Formatting done to fit within 80 columns

joaosaffran · 2025-08-30T01:22:52Z

llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp

+  StringRef RCName = getResourceClassName(RC);
+  OS << RCName << " at register " << Binding.LowerBound << " and space "
+     << Binding.Space << " is bound to a texture or typed buffer. " << RCName
+     << " root descriptors can only be Raw or Structured buffers.";


Last sentence added to match DXC diagnostic message

joaosaffran · 2025-08-30T01:24:50Z

llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp

+      const auto *ParamInfo =
+          static_cast<const mcdxbc::RootParameterInfo *>((*Reg)->Cookie);
+
+      if (RC != ResourceClass::SRV && RC != ResourceClass::UAV)
+        continue;
+
+      if (ParamInfo->Type == dxbc::RootParameterType::DescriptorTable)
+        continue;
+
+      if (RK != ResourceKind::RawBuffer && RK != ResourceKind::StructuredBuffer)
+        reportInvalidHandleTyError(M, RC, Binding);


Using continues instead of long bool expression, as recommended in llvm coding guides: https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code

joaosaffran · 2025-08-30T01:25:56Z

llvm/test/CodeGen/DirectX/rootsignature-validation-textures.ll

@@ -0,0 +1,17 @@
+; RUN: opt -S -passes='dxil-post-optimization-validation' -mtriple=dxil-pc-shadermodel6.6-compute %s 
+; "This is a valid root signature with a texture/typed buffer resource"


This is using descriptor table instead of root descriptors, that is why it is allowed, as far as my understanding of DXC goes

joaosaffran · 2025-08-30T01:26:14Z

llvm/test/CodeGen/DirectX/rootsignature-validation-typedbuffer.ll

@@ -0,0 +1,17 @@
+; RUN: opt -S -passes='dxil-post-optimization-validation' -mtriple=dxil-pc-shadermodel6.6-compute %s 2>&1 
+; This is a valid root signature with a texture/typed buffer resource


Same as previous valid test

bogner · 2025-09-10T16:59:04Z

llvm/include/llvm/Frontend/HLSL/HLSLBinding.h

@@ -133,17 +133,21 @@ class BoundRegs {
 public:
  BoundRegs(SmallVector<Binding> &&Bindings) : Bindings(std::move(Bindings)) {}

-  bool isBound(dxil::ResourceClass RC, uint32_t Space, uint32_t LowerBound,
-               uint32_t UpperBound) const {
+  std::optional<const Binding *> findBoundReg(dxil::ResourceClass RC,


std::optional<> of a pointer type is weird - pointers are already nullable. Better to just return the pointer directly and use nullptr for not found.

bogner · 2025-09-10T17:03:16Z

llvm/lib/Target/DirectX/DXILPostOptimizationValidation.cpp

@@ -118,6 +118,17 @@ static void reportOverlappingBinding(Module &M, DXILResourceMap &DRM) {
                       "true, yet no overlapping binding was found");
 }

+static void reportInvalidHandleTyError(Module &M, ResourceClass RC,
+                                       ResourceInfo::ResourceBinding Binding) {
+  SmallString<128> Message;


The message here is always longer than 128 characters, so this SmallString is never able to use its "small" storage. We should bump this to something like 160 and avoid an unnecessary heap allocation

bogner · 2025-09-10T17:08:02Z

llvm/test/CodeGen/DirectX/rootsignature-validation-textures-fail.ll

+
+define void @CSMain() "hlsl.shader"="compute" {
+entry:
+  %TB =  tail call target("dx.Texture", float, 1, 0, 0, 4) @llvm.dx.resource.handlefrombinding.tdx.TypedBuffer_f32_1_0_0t(i32 0, i32 0, i32 1, i32 0, ptr nonnull @TB.str)


You can skip the overload type here and let the IR parser add it implicitly

Suggested change

%TB = tail call target("dx.Texture", float, 1, 0, 0, 4) @llvm.dx.resource.handlefrombinding.tdx.TypedBuffer_f32_1_0_0t(i32 0, i32 0, i32 1, i32 0, ptr nonnull @TB.str)

%TB = tail call target("dx.Texture", float, 1, 0, 0, 4) @llvm.dx.resource.handlefrombinding(i32 0, i32 0, i32 1, i32 0, ptr nonnull @TB.str)

Similarly in the other tests.

bogner · 2025-09-10T17:09:58Z

llvm/test/CodeGen/DirectX/rootsignature-validation-textures.ll

It might be better to name this test "valid" rather than "validation" like rootsignature-valid-textures.ll. I think it's a bit clearer.

bogner · 2025-09-10T21:06:41Z

llvm/test/CodeGen/DirectX/rootsignature-validation-typedbuffer.ll

Should rename this test to match the new name on rootsignature-valid-textures.ll

Sorry, missed this one

…//github.com/joaosaffran/llvm-project into validation/textures-not-bind-root-signatures

joaosaffran added 23 commits June 26, 2025 19:34

refactoring

0e8828c

refactoring

2edd215

clean up

242545e

format

3f8dec4

formating

3b1ce3b

fix import issues

f5720af

formating

ea54904

refactoring

a49aa19

init refactoring

d90676f

adding validation

a04eb9f

clean

5994b8f

implementing

e8b14bf

finish implementing && fix tests

8f40e83

fix issue

28350b2

sync parent

4fd2e0b

sync parent

e25ee87

add validation

01a558b

address comments

881dd36

Merge branch 'refactoring/updating-return-root-sig-analysis' into val…

8779ee9

…idation/check-descriptors-are-bound

adding validation

43eb04e

fix test

c16f15b

Merge branch 'validation/check-descriptors-are-bound' into validation…

f67bec1

…/textures-not-bind-root-signatures

format

d7b4cf4

llvmbot added clang Clang issues not falling into any other category backend:DirectX HLSL HLSL Language Support labels Jul 8, 2025

format

c7d5be7

joaosaffran added 5 commits August 21, 2025 12:52

making BindingRange const

e902add

doing it again for other isBound

9a6d64c

adding DXILResourceTypeMap

15b7592

updating error messages and tests

11b9fb2

Merge branch 'validation/check-descriptors-are-bound' into validation…

0b8a997

…/textures-not-bind-root-signatures

joaosaffran marked this pull request as draft August 28, 2025 21:11

Merge branch 'main' into validation/textures-not-bind-root-signatures

17b425d

joaosaffran changed the base branch from users/joaosaffran/146785 to main August 29, 2025 00:00

joaosaffran added 4 commits August 28, 2025 23:23

refactoring

f9c4b9c

adding comment

c7cedb4

refactoring isBound to return the bound reg

bf9b30c

formating

18e4c3d

joaosaffran commented Aug 30, 2025

View reviewed changes

joaosaffran requested a review from inbelic August 30, 2025 01:26

joaosaffran marked this pull request as ready for review August 30, 2025 01:26

bogner reviewed Sep 10, 2025

View reviewed changes

joaosaffran added 4 commits September 10, 2025 11:34

remove optional from type

3f83308

changing small string size

8daa97b

fixing tests

79f1f48

removing type from handlefrombinding

3d10d92

joaosaffran requested a review from bogner September 10, 2025 18:48

Merge branch 'main' into validation/textures-not-bind-root-signatures

f596ad5

bogner approved these changes Sep 10, 2025

View reviewed changes

joaosaffran added 2 commits September 10, 2025 14:50

renamig tests

55c2b96

Merge branch 'validation/textures-not-bind-root-signatures' of https:…

d1c31f1

…//github.com/joaosaffran/llvm-project into validation/textures-not-bind-root-signatures

joaosaffran merged commit 9179d3f into llvm:main Sep 10, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

joaosaffran commented Jul 8, 2025 •

edited

Loading

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

joaosaffran Aug 30, 2025

Uh oh!

joaosaffran Aug 30, 2025

Uh oh!

joaosaffran Aug 30, 2025

Uh oh!

joaosaffran Aug 30, 2025

Uh oh!

joaosaffran Aug 30, 2025

Uh oh!

bogner Sep 10, 2025

Uh oh!

bogner Sep 10, 2025

Uh oh!

bogner Sep 10, 2025

Uh oh!

bogner Sep 10, 2025

Uh oh!

bogner Sep 10, 2025

Uh oh!

joaosaffran Sep 10, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -0,0 +1,17 @@
		; RUN: opt -S -passes='dxil-post-optimization-validation' -mtriple=dxil-pc-shadermodel6.6-compute %s
		; "This is a valid root signature with a texture/typed buffer resource"

		@@ -0,0 +1,17 @@
		; RUN: opt -S -passes='dxil-post-optimization-validation' -mtriple=dxil-pc-shadermodel6.6-compute %s 2>&1
		; This is a valid root signature with a texture/typed buffer resource

	%TB = tail call target("dx.Texture", float, 1, 0, 0, 4) @llvm.dx.resource.handlefrombinding.tdx.TypedBuffer_f32_1_0_0t(i32 0, i32 0, i32 1, i32 0, ptr nonnull @TB.str)
	%TB = tail call target("dx.Texture", float, 1, 0, 0, 4) @llvm.dx.resource.handlefrombinding(i32 0, i32 0, i32 1, i32 0, ptr nonnull @TB.str)

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

[DirectX] Validate if Textures/TypedBuffers are being bound in Root Signatures #147573

Conversation

joaosaffran commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

llvmbot commented Jul 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joaosaffran commented Jul 8, 2025 •

edited

Loading