[lldb][windows] enable CI tests#198906
Conversation
|
@llvm/pr-subscribers-lldb @llvm/pr-subscribers-infrastructure Author: Charles Zablit (charles-zablit) Changesfix #132800. Full diff: https://github.com/llvm/llvm-project/pull/198906.diff 1 Files Affected:
diff --git a/.ci/compute_projects.py b/.ci/compute_projects.py
index 97caec7ad947d..496fad5f5ed70 100644
--- a/.ci/compute_projects.py
+++ b/.ci/compute_projects.py
@@ -201,12 +201,7 @@
# where a project can be built but its tests are not yet stable on that
# platform, so we still want a compile-time signal.
PROJECT_CHECK_TARGETS_OVERRIDE = {
- "Windows": {
- # TODO(issues/132800): LLDB tests need environment setup on Windows.
- # In the meantime, at least compile lldb and lldb-dap to catch
- # breakage.
- "lldb": "lldb lldb-dap",
- },
+ "Windows": {},
}
|
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
🪟 Windows x64 Test Results
✅ The build succeeded and all tests passed. |
boomanaiden154
left a comment
There was a problem hiding this comment.
Can we add a test case in compute_projects_test.py?
I'm also not sure that we want to run LLDB by default on clang/LLVM changes like we do on Linux given we're a bit more constrained timing wise on Windows, although that might change soon with daemonized testing.
| @@ -201,12 +201,7 @@ | |||
| # where a project can be built but its tests are not yet stable on that | |||
| # platform, so we still want a compile-time signal. | |||
| PROJECT_CHECK_TARGETS_OVERRIDE = { | |||
There was a problem hiding this comment.
We can probably drop this completely now.
58cb78f to
724f518
Compare
|
Converting to draft until all the tests pass. |
|
ping @boomanaiden154, all the tests are passing now. |
boomanaiden154
left a comment
There was a problem hiding this comment.
Thanks, this largely looks good. If we can split off the LLDB test changes I think this should be good to go.
| class TestDAP_restart_console(lldbdap_testcase.DAPTestCaseBase): | ||
| @skipIfAsan | ||
| @expectedFailureWindows | ||
| @skipIfWindows # https://github.com/llvm/llvm-project/issues/200840 |
There was a problem hiding this comment.
Can this be split into a separate PR for LLDB people to look at?
There was a problem hiding this comment.
Sure, I opened #201587 to skip it. I will rebase once it's merged.
`TestDAP_restart_console` is already failing on Windows. It reliably crashes (UNRESOLVED) on some Windows version, including inside Docker containers. This is preventing us from enabling pre-merge CI testing for lldb on Windows in #198906. This patch skips the test entirely. See #200840 for more details.
3bc100c to
4a96f22
Compare
| self.assertEqual(env_variables["runtimes_check_targets"], "") | ||
| self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "") | ||
|
|
||
| def test_lldb(self): |
There was a problem hiding this comment.
We should keep this test unless there's a reason I'm missing for why we're dropping it.
There was a problem hiding this comment.
I was going to say that I removed them because lldb was added to EXCLUDE_DEPENDENTS_WINDOWS, but that impacts test_lldb_windows, not this test. I've reverted that change.
`TestDAP_restart_console` is already failing on Windows. It reliably crashes (UNRESOLVED) on some Windows version, including inside Docker containers. This is preventing us from enabling pre-merge CI testing for lldb on Windows in llvm/llvm-project#198906. This patch skips the test entirely. See llvm/llvm-project#200840 for more details.
`TestDAP_restart_console` is already failing on Windows. It reliably crashes (UNRESOLVED) on some Windows version, including inside Docker containers. This is preventing us from enabling pre-merge CI testing for lldb on Windows in llvm/llvm-project#198906. This patch skips the test entirely. See llvm/llvm-project#200840 for more details.
This patch enables CI testing for lldb on Windows. It skips dependent PR testing for now until we enable daemonized testing.
This patch also skips
TestDAP_restart_consoleon Windows because it's failing on the bots and is unresolved in the docker container. See #200840 fore more details.fix #132800.