[lldb-dap][Windows] skip TestDAP_restart_console#201587
Merged
charles-zablit merged 1 commit intoJun 4, 2026
Merged
Conversation
|
@llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) Changes
This is preventing us from enabling pre-merge CI testing for lldb on Windows in #198906. This patch skips the test entirely. See #200840 for more details. Full diff: https://github.com/llvm/llvm-project/pull/201587.diff 1 Files Affected:
diff --git a/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py b/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py
index c80a3cdc10d95..e10d6791eeaf2 100644
--- a/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py
+++ b/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_console.py
@@ -12,7 +12,7 @@
@skipIfBuildType(["debug"])
class TestDAP_restart_console(lldbdap_testcase.DAPTestCaseBase):
@skipIfAsan
- @expectedFailureWindows
+ @skipIfWindows # https://github.com/llvm/llvm-project/issues/200840
@skipIf(oslist=["linux"], archs=["arm$"]) # Always times out on buildbot
def test_basic_functionality(self):
"""
@@ -61,7 +61,7 @@ def test_basic_functionality(self):
self.continue_to_exit()
@skipIfAsan
- @expectedFailureWindows
+ @skipIfWindows # https://github.com/llvm/llvm-project/issues/200840
@skipIf(oslist=["linux"], archs=["arm$"]) # Always times out on buildbot
def test_stopOnEntry(self):
"""
|
Nerixyz
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDAP_restart_consoleis already failing on Windows. It reliably crashes (UNRESOLVED) on some Windows version, including inside Docker containers.This is preventing us from enabling pre-merge CI testing for lldb on Windows in #198906.
This patch skips the test entirely. See #200840 for more details.