Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HIP] Add cuda_wrapper tests from Externals/CUDA using hipify-perl #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[HIP] Add cuda_wrapper tests from Externals/CUDA using hipify-perl #243

wants to merge 1 commit into from

Conversation

jmmartinez
Copy link

This PR tries to adapt in a pretty rough way some tests from Externals/CUDA that test interactions with cuda_wrapper headers.

This catch the bug fixed by llvm/llvm-project#139697

@jmmartinez jmmartinez requested a review from yxsamliu May 13, 2025 09:50
@jmmartinez jmmartinez self-assigned this May 13, 2025
@jmmartinez
Copy link
Author

jmmartinez commented May 13, 2025 •
edited
Loading

I'm not happy with this. Ideally, we could put CUDA and HIP common tests together. This is a first step to get some initial feedback (and see what the validation has to say about it).

@jmmartinez jmmartinez requested a review from jplehr May 13, 2025 09:52
@jmmartinez jmmartinez force-pushed the cuda_wrappers/hip branch from 1849bc4 to 4c88c3e Compare May 13, 2025 09:58
@jmmartinez jmmartinez mentioned this pull request May 13, 2025
Open
@jmmartinez jmmartinez force-pushed the cuda_wrappers/hip branch from 4c88c3e to 2f699f4 Compare May 16, 2025 07:53
@jmmartinez jmmartinez mentioned this pull request May 16, 2025
Draft
@jmmartinez jmmartinez requested review from emankov and kzhuravl May 16, 2025 07:56
@jmmartinez jmmartinez changed the title [HIP] rough way of adding cuda_wrapper tests from Externals/CUDA [HIP] Add cuda_wrapper tests from Externals/CUDA using hipify-perl May 16, 2025
@jmmartinez jmmartinez force-pushed the cuda_wrappers/hip branch from 2f699f4 to 4abe1ec Compare May 16, 2025 12:31
@jmmartinez
Copy link
Author

@jplehr do you have some advice about how I can ensure that this change doesn't break any of our buildbots ?

I've run the test locally and it works. I still have to ensure that hipify-perl is installed on our test images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxsamliu yxsamliu Awaiting requested review from yxsamliu

@jplehr jplehr Awaiting requested review from jplehr

@emankov emankov Awaiting requested review from emankov

@kzhuravl kzhuravl Awaiting requested review from kzhuravl

Assignees

@jmmartinez jmmartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmmartinez