Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Fix CI broken link checks #905

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Fix CI broken link checks #905

merged 2 commits into from
Nov 9, 2023

Conversation

simonrw
Copy link
Contributor

@simonrw simonrw commented Nov 9, 2023

Motivation

It seems merging #892 broke the broken link checker. This may be because the config file previously had an incorrect format, and was therefore invalid JSON, however it is confusing that the pipeline did not fail at any point.

Regardless, some broken links were found:

  • the use of local.localstack.cloud (rather than localhost.localstack.cloud)
  • links to removed neptune API reference

Changes

This PR fixes the two points listed above, and fixes the broken link checker.

@simonrw simonrw self-assigned this Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

⚡️ Deploying PR Preview...

@simonrw simonrw force-pushed the fix/ci/lint-checks branch from ef34251 to 9a44f28 Compare November 9, 2023 11:29
@simonrw simonrw changed the base branch from release/v3.0 to main November 9, 2023 11:29
@simonrw simonrw changed the base branch from main to release/v3.0 November 9, 2023 11:33
@simonrw simonrw marked this pull request as ready for review November 9, 2023 11:33
@simonrw simonrw mentioned this pull request Nov 9, 2023
15 tasks
Copy link
Member

@joe4dev joe4dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thanks for jumping on that.

@simonrw simonrw merged commit 18f85df into release/v3.0 Nov 9, 2023
@simonrw simonrw deleted the fix/ci/lint-checks branch November 9, 2023 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants