Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove extensions api from coverage collection #6715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

thrau
Copy link
Member

@thrau thrau commented Aug 21, 2022

Remvoes localstack.extensions.api, which is just a set of import statements, from the coverage metrics. Extensions will be tested as part of pro

@thrau thrau requested a review from alexrashed August 21, 2022 13:46
@thrau thrau temporarily deployed to localstack-ext-tests August 21, 2022 13:46 Inactive
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 91.544% when pulling d6f316e on extensions-api-coverage into ae4a2ad on master.

@github-actions
Copy link

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 18m 40s ⏱️ + 5m 51s
1 205 tests ±0  1 164 ✔️ ±0  41 💤 ±0  0 ±0 
1 586 runs  ±0  1 514 ✔️ ±0  72 💤 ±0  0 ±0 

Results for commit d6f316e. ± Comparison against base commit ae4a2ad.

Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 📈

@thrau thrau merged commit 1d7ac0f into master Aug 22, 2022
@thrau thrau deleted the extensions-api-coverage branch August 22, 2022 22:41
@thrau
Copy link
Member Author

thrau commented Aug 23, 2022

hmm, this seems to have had no effect 🤔 extensions coverage is still at 0%

@alexrashed
Copy link
Member

Actually, other exclusions don't work either.
Just took a look at the config:

  • The configuration should be fine (we use the coverage package with the toml extra, which allows setting the config in the pyproject.toml).
  • The section in the pyproject.toml is named correctly.
  • The section to omit files is correct as well.
  • I think the issue is that the exclusions are not proper file name patterns as described in the config:

    The include and omit file name patterns follow typical shell syntax: * matches any number of characters and ? matches a single character. Patterns that start with a wildcard character are used as-is, other patterns are interpreted relative to the current directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants