fix coverage exclusions #6833
Merged
fix coverage exclusions #6833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
Sep 7, 2022
There was a problem hiding this comment.
Thanks for tackling this @alexrashed ! 👍 Agree that it's better to report on the true net coverage and not green-wash the results. This will be a motivation to bump the coverage up into the green range again! 🚀 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
coverageconfig to:localstack/infraandlocalstack/node_modules, since these directories are not used anymore (since add new localstack filesystem hierarchy #6302).I verified the settings with the following commands locally:
This PR will unfortunately lower the code coverage percentage quite a lot, since the generated APIs had a high coverage:
However, we don't want to green-wash our results. Once this PR is merged we can substantially increase the code coverage by identifying currently uncovered code and either removing it (if it's dead code), or write tests for these uncovered sections.
/cc @bentsku @thrau